-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use better-sqlite3 instead of sqlite3 for performance #100
Comments
This looks very promising. I would like to take a look. @springmeyer @kkaefer What do you think about it? |
One issue might be that the extension is compiled at install time meaning
that you should have a dev environment installed where you install the lib.
OTOH I think sqlite3 comes pre-built.
If I remember correctly there is an issue on the better-sqlite3 repo.
…On Mon, Sep 16, 2019 at 7:25 PM jingsam ***@***.***> wrote:
This looks very promising. I would like to take a look. @springmeyer
<https://github.com/springmeyer> @kkaefer <https://github.com/kkaefer>
What do you think about it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#100?email_source=notifications&email_token=AAB4X4SN4IBQYQX7PHNKZW3QKA523A5CNFSM4IV6GHU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD63CKQQ#issuecomment-532030786>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB4X4UXNNOJRDW7MYL4FGLQKA523ANCNFSM4IV6GHUQ>
.
|
This seems like reasonable thing to consider. To approve the switch I'd want to see a benchmark written that replicates an important usecase of node-mbtiles and shows that the switch concretely improves performance (both increased speed and reduced memory usage). So the benchmark should be able to be run against both node-sqlite3 and better-sqlite3. We could each run that benchmark on a few different machines to ensure that the code is working well with better-sqlite3. |
Yes, node-sqlite3 provides pre-built binaries. Ideally better-sqlite3 would too. But that does not need to be a blocker for writing a benchmark to compare. |
Seems like the sqlite version this package is using is kind-of wrapped around the axle. Suggestions? |
I have found better-sqlite3 to perform much better than sqlite3 on one of my project.
They advertise that speed and also have better docs.
If you are interested in switching, I could work on the PR, let me know.
Note: #96 might be related.
The text was updated successfully, but these errors were encountered: