You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When programatically eiditing v8.json (and other JSON files), it would be helpful to use a JSON formatter so changes do not introduce unrelated (formatting) changes.
This has the advantage that we can enable pre-commit.ci which can automatically apply fixes on PRs (this is very convenient). But pre-commit is written in Python and it's another tool to introduce.
I prefer eslint, which I think somewhat is already in use for the typescript code.
I don't like pre-commit stuff as they annoy when you want to commit.
PR checks are sufficient, IMHO.
When programatically eiditing
v8.json
(and other JSON files), it would be helpful to use a JSON formatter so changes do not introduce unrelated (formatting) changes.There are some options:
Use an eslint plugin such as https://github.com/ota-meshi/eslint-plugin-jsonc
Use the
pretty-format-json
hook of pre-commit https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#pretty-format-jsonThis has the advantage that we can enable pre-commit.ci which can automatically apply fixes on PRs (this is very convenient). But pre-commit is written in Python and it's another tool to introduce.
The text was updated successfully, but these errors were encountered: