Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A beginner's contribution to enhance understanding #169

Closed
lenaigmoign opened this issue Jun 14, 2023 · 4 comments · Fixed by #206
Closed

A beginner's contribution to enhance understanding #169

lenaigmoign opened this issue Jun 14, 2023 · 4 comments · Fixed by #206
Assignees

Comments

@lenaigmoign
Copy link

About the output-wide vignette :
"In this case, the result has 9 rows just like the original data frame.
We can now export our portfolio for example as a geopackage that can be read directly into e.g. QGIS or as a CSV without the geospatial information"

It could be interesting to add a sentence between the two lines to emphasize the connection with the wide format, for example :
"In this particular scenario, where the only variable is elevation_mean, the object port_wide_1 contains just one value per polygon.
This aligns well with the characteristics of the wide format, which can be easily understood and processed by various (geospatial) software."

I tried the tutorial following @fBedecarrats suggestion, and I have nothing to criticize. It's really well-explained and didactic.

@fBedecarrats
Copy link
Collaborator

Thank you for the feedback @lenaigmoign. @goergen95 , @Jo-Schie , as she is starting to use the package and does not have a lot of experience with R (but learns VERY fast), @lenaigmoign seems the perfect target for the documentation. She was puzzled by the long/wide outputs so I recommended that she reads the new vignette, and asked her for a feedback to confirm that it was clear and didactic. Thanks to her!

@goergen95
Copy link
Member

Thank you very much for your feedback on the new vignette! Glad to hear that it does a good job at explaining wide vs. long format.

I would be very happy to include your suggested changes. Please provide them as a Pull-Request because that is the usual way how we would expect feedback concerning the documentation.

@fBedecarrats
Copy link
Collaborator

@lenaigmoign is new to Github. I will prepare the pull request.

@goergen95
Copy link
Member

Thanks a lot @lenaigmoign. I included your suggestions in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants