Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter/return is borked on Chrome/Mac OS. #59

Open
hellige opened this issue May 6, 2012 · 1 comment
Open

Enter/return is borked on Chrome/Mac OS. #59

hellige opened this issue May 6, 2012 · 1 comment

Comments

@hellige
Copy link

hellige commented May 6, 2012

Tested in goforth: http://0x10co.de/hiwhx

Goforth expects enter to send the keycode spec'ed in the keyboard spec. 0x10co.de does generate that keycode, but then it also generates an extra 0x13. It looks like the key is being triggered through both the keydown event and the keypress event. The keypress event doesn't check keyMap, which explains why it's not being converted. But either way, it's extra.

Changing line 413 of ui.js to:
if(e.which >= 37 && e.which <= 40 || e.which === 8 || e.which === 13) e.preventDefault();
fixes it.

@Cheesier
Copy link

Cheesier commented May 8, 2012

I have noticed the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants