Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing translated strings while possible #2380

Open
overflorian opened this issue Jul 11, 2024 · 3 comments
Open

Use existing translated strings while possible #2380

overflorian opened this issue Jul 11, 2024 · 3 comments
Labels
enhancement New feature or request l10n

Comments

@overflorian
Copy link

Hi, Transifex suggests me to translate the very basic word "Challenge" (see https://app.transifex.com/osmlab/maproulette3/translate/#fr/en-us-json/476126110) even if it has already been translated before (see https://app.transifex.com/osmlab/maproulette3/translate/#fr/en-us-json/170937424).

I suggest that you re-use the same translation string when exactly the same, avoiding the interface not being fully translated for no reason + avoid some translators time too.

@mvexel
Copy link
Member

mvexel commented Jul 11, 2024

I agree that seems silly. Moreover, we already have challenge as a glossary term already. What would be involved in streamlining this @jschwarz2030 @CollinBeczak ?

@mvexel mvexel added the l10n label Jul 11, 2024
@CollinBeczak
Copy link
Collaborator

This can be done relatively easily, all of these duplicate terms have unique ids, these ids are usually related to the feature they are associated with. So if we were to take the approach as described above and remove duplicates, we would probably want to replace all those with a new id that is not tied to a particular context like id: "challenge" instead of id: "Inbox.tableHeaders.challengeName". The only annoyance i see with this from a translator perspective is that they will need to re translate all the strings that had duplicates.

@mvexel
Copy link
Member

mvexel commented Jul 12, 2024

My sense is that the benefits outweigh that inconvenience, but I can't quite assess the impact on translators. Let's keep this open for a bit and give others a chance to weigh in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request l10n
Projects
Development

No branches or pull requests

3 participants