Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding further filtering rules in context-based post processing #344

Open
rwood-97 opened this issue Jan 30, 2024 · 0 comments
Open
Labels
enhancement New feature or request new feature post-processing Issues related to the "Post-Process" functionality

Comments

@rwood-97
Copy link
Collaborator

rwood-97 commented Jan 30, 2024

Currently the only post-processing option is to filter for patches with no surrounding patches labelled as the same thing (e.g. an isolated railspace patch) and relabel these as non-railspace if below a certain model confidence. As per Ed's suggestion (below), if we want to add further post processing options within the MapReader pipeline we could allow users to define their own rules as opposed to having it 'built in'.

+ves of this are that this enables much broader post-processing options
-ves of this are complexity (for users with limited coding experience) and also the need to evaluate post-processing results

We should consider this for future work.

I think that this line is the filtering rule? If so, might it make sense to separate it as it's own function and give it a name. The name could be filter_rule_1 with a docstring that explains the logic in plain English like "If patch has label X but no surrounding patches have label X, remove label X from patch"

What you could do then is have an arg for update_preds called filter_func. You could pass in the filter function when it's called and the filter function would be called on this line. This would mean you could substitute in a different filter function.

So all you have to do to try out a different filter rule is write another small function and call update_preds like patches.update_preds(filter_func=filter_rule_2 ... other args)

Originally posted by @edwardchalstrey1 in #342 (comment)

@rwood-97 rwood-97 added enhancement New feature or request new feature post-processing Issues related to the "Post-Process" functionality labels Jan 30, 2024
@rwood-97 rwood-97 moved this from Upcoming to Backlog in MapReader Project Board -- legacy Feb 15, 2024
@kallewesterling kallewesterling moved this to Backlog in MapReader Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature post-processing Issues related to the "Post-Process" functionality
Projects
Status: Freezer
Development

No branches or pull requests

1 participant