Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix review_labels #432

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix review_labels #432

merged 1 commit into from
May 15, 2024

Conversation

rwood-97
Copy link
Collaborator

Summary

Fixes #400

Describe your changes

Previous code allowed you enter a new label when reviewing labels but would give you an error (even though it relabelled the patch fine). Now we give an error and only allow user to enter one of the existing labels when re-labelling/reviewing their annotations.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@rwood-97 rwood-97 added the bug Something isn't working label May 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.45%. Comparing base (3d0aae0) to head (ca42977).

Files Patch % Lines
mapreader/classify/load_annotations.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   62.48%   62.45%   -0.03%     
==========================================
  Files          39       39              
  Lines        6771     6774       +3     
==========================================
  Hits         4231     4231              
- Misses       2540     2543       +3     
Flag Coverage Δ
unittests 62.45% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwood-97 rwood-97 merged commit db75647 into main May 15, 2024
6 checks passed
@rwood-97 rwood-97 deleted the 400-review-labels branch May 15, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Error if you type a new label when using review_labels().
2 participants