Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker image is hardcoded in cluster.py #1

Open
mapsacosta opened this issue Oct 5, 2023 · 2 comments
Open

Worker image is hardcoded in cluster.py #1

mapsacosta opened this issue Oct 5, 2023 · 2 comments
Assignees

Comments

@mapsacosta
Copy link
Owner

We are currently just assuming that the latest coffea-dask image is what the user wants, this is no longer the case as we need to be able to adjust it as needed.

A breaking change upgrading to python3.10 in docker-coffea-dask motivated this use-case.

https://github.com/mapsacosta/htcdaskgateway/blob/main/src/htcdaskgateway/cluster.py#L70 <--- this is where the image is hardcoded

It would be ideal for someone to go:

gateway = HTCGateway()
cluster = gateway.new_cluster(image_name=f"/cvmfs/unpacked.cern.ch/registry.hub.docker.com/coffeateam/coffea-dask-cc7-gateway:<your_version")
@mapsacosta
Copy link
Owner Author

@Nanoemc let's use this issue to follow-up on the testing for this feature

@nsmith-
Copy link

nsmith- commented Sep 18, 2024

A similar problem still exists, where the image prefix is hardcoded in:

image_name = f"/cvmfs/unpacked.cern.ch/registry.hub.docker.com/" + self.condor_image

It would be nice to have the option to specify the full path
cc @dalfonso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants