Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paperSize border deprecated #403

Open
jer-sen opened this issue Mar 2, 2018 · 0 comments · May be fixed by #412
Open

paperSize border deprecated #403

jer-sen opened this issue Mar 2, 2018 · 0 comments · May be fixed by #412

Comments

@jer-sen
Copy link

jer-sen commented Mar 2, 2018

border should be replaced by margin : http://phantomjs.org/api/webpage/property/paper-size.html

TomCoded added a commit to TomCoded/node-html-pdf that referenced this issue Mar 19, 2018
margin replaced border six years ago in phantomJS, although
backward compatibility still allows the border property
to function correctly.

This change updates html-pdf to use the margin property and
to continue recognizing the border property for backward
compatitiblity.

fixes: marcbachmann#403
refs: ariya/phantomjs@a638a07
TomCoded added a commit to TomCoded/node-html-pdf that referenced this issue Mar 19, 2018
margin replaced border six years ago in phantomJS, although
backward compatibility still allows the border property
to function correctly.

This change updates html-pdf to use the margin property and
to continue recognizing the border property for backward
compatitiblity.

fixes: marcbachmann#403
refs: ariya/phantomjs@a638a07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant