From 8a749faa9187263e206b347ec03c99a66113171a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jules=20Franc=CC=A7oise?= <me@julesfrancoise.com>
Date: Tue, 12 Oct 2021 13:55:53 +0200
Subject: [PATCH 1/6] MLP : throw an error if the dataset is empty

---
 src/components/mlp-classifier/mlp-classifier.component.ts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/components/mlp-classifier/mlp-classifier.component.ts b/src/components/mlp-classifier/mlp-classifier.component.ts
index 59cee498..6f844ae4 100644
--- a/src/components/mlp-classifier/mlp-classifier.component.ts
+++ b/src/components/mlp-classifier/mlp-classifier.component.ts
@@ -20,6 +20,7 @@ import {
 import type { ServiceIterable } from '../../core/data-store/service-iterable';
 import { Dataset, isDataset } from '../../core/dataset';
 import { Catch, TrainingError } from '../../utils/error-handling';
+import { throwError } from '../../utils/error-handling';
 
 interface TrainingData {
   training_x: Tensor2D;
@@ -130,6 +131,13 @@ export class MLPClassifier extends TFJSBaseModel<TensorLike, ClassifierResults>
       : (this.labels = Array.from(new Set(await dataset.map(({ y }) => y).toArray())));
     const ds = isDataset(dataset) ? dataset.items() : dataset;
     this.$training.set({ status: 'start', epochs: this.parameters.epochs.value });
+    if (this.labels.length === 0) {
+      throwError(new TrainingError('This dataset is empty or is missing labels'));
+      this.$training.set({
+        status: 'error',
+      });
+      return;
+    }
     setTimeout(async () => {
       const data = await dataSplit(ds, 0.75, this.labels);
       this.buildModel(data.training_x.shape[1], data.training_y.shape[1]);

From d996756f357b3df41d089be801aca0618a9b0c34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jules=20Franc=CC=A7oise?= <me@julesfrancoise.com>
Date: Tue, 12 Oct 2021 14:22:05 +0200
Subject: [PATCH 2/6] Various fixes in the training history component

- bug with row selection and page changes
- bug with training run indexing from the browser
- bug with concurrent calls in training tracking
---
 .../training-history/training-history.component.ts     | 10 +++++++++-
 .../training-history/training-history.view.svelte      |  6 +++++-
 src/ui/components/Table.svelte                         |  9 +++------
 3 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/src/components/training-history/training-history.component.ts b/src/components/training-history/training-history.component.ts
index 55c95f0b..1d25d62d 100644
--- a/src/components/training-history/training-history.component.ts
+++ b/src/components/training-history/training-history.component.ts
@@ -1,6 +1,7 @@
 import { Paginated, Service } from '@feathersjs/feathers';
 import { logger, Model, Component, Stream, TrainingRun, TrainingStatus } from '../../core';
 import { DataStore } from '../../core/data-store';
+import { preventConcurrentCalls } from '../../utils/asynchronicity';
 import { noop } from '../../utils/misc';
 import View from './training-history.view.svelte';
 
@@ -38,6 +39,8 @@ export class TrainingHistory<InputType, OutputType> extends Component {
   protected modelName: string;
   protected nextIndex: number;
 
+  private lock = Promise.resolve();
+
   constructor(public dataStore: DataStore, options: TrainingHistoryOptions = {}) {
     super();
     this.options = { ...defaultOptions, ...options };
@@ -71,7 +74,7 @@ export class TrainingHistory<InputType, OutputType> extends Component {
       })
       .then(({ data: foundRuns }) => {
         if (foundRuns.length > 0) {
-          return parseInt(foundRuns[0].name.split(`${name}-`)[1]) + 1;
+          return parseInt(foundRuns[0].name.split(`${basename}-`)[1]) + 1;
         }
         return 1;
       })
@@ -85,6 +88,7 @@ export class TrainingHistory<InputType, OutputType> extends Component {
     return this;
   }
 
+  @preventConcurrentCalls('lock')
   protected async trackTrainingStream(x: TrainingStatus): Promise<void> {
     if (x.status === 'start') {
       this.crtRun = await this.runService.create({
@@ -119,6 +123,10 @@ export class TrainingHistory<InputType, OutputType> extends Component {
           },
         ]),
       });
+    } else if (x.status === 'error') {
+      this.runService.patch(this.crtRun.id, {
+        status: x.status,
+      });
     }
   }
 
diff --git a/src/components/training-history/training-history.view.svelte b/src/components/training-history/training-history.view.svelte
index 690672e9..bae701e4 100644
--- a/src/components/training-history/training-history.view.svelte
+++ b/src/components/training-history/training-history.view.svelte
@@ -47,6 +47,10 @@
     },
   });
 
+  provider.data.subscribe(() => {
+    selection.set([]);
+  });
+
   const columns: Column[] = [
     { name: 'name', sortable: true },
     { name: 'start', sortable: true, type: 'date' },
@@ -82,7 +86,7 @@
     {provider}
     actions={[
       ...actions.map((name) => (typeof name === 'string' ? { name } : name)),
-      { name: 'remove', confirm: true },
+      { name: 'delete', confirm: true },
     ]}
     bind:selection={$selection}
     bind:this={mainTable}
diff --git a/src/ui/components/Table.svelte b/src/ui/components/Table.svelte
index 19908a70..0a1be66a 100644
--- a/src/ui/components/Table.svelte
+++ b/src/ui/components/Table.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-  import { createEventDispatcher, onMount } from 'svelte';
+  import { createEventDispatcher } from 'svelte';
   import TableContentCell from './TableContentCell.svelte';
   import TableHeaderCell from './TableHeaderCell.svelte';
   import TableFooter from './TableFooter.svelte';
@@ -18,10 +18,7 @@
 
   $: data = provider.data;
   $: error = provider.error;
-
-  onMount(() => {
-    selected = selection.map((x) => get(data).indexOf(x));
-  });
+  $: selected = selection.map((x) => get(data).indexOf(x));
 
   const dispatch = createEventDispatcher();
 
@@ -93,7 +90,7 @@
             {#if !singleSelection}
               <input
                 type="checkbox"
-                checked={selected.length === $data.length}
+                checked={selected.length > 0 && selected.length === $data.length}
                 on:click={selectAll}
               />
             {/if}

From eb89eac6433d50600787dd63b644125dd4e0962d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jules=20Franc=CC=A7oise?= <me@julesfrancoise.com>
Date: Tue, 12 Oct 2021 14:31:06 +0200
Subject: [PATCH 3/6] Fix border color of image selection in dataset browser

---
 src/components/dataset-browser/dataset-browser.view.svelte | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/components/dataset-browser/dataset-browser.view.svelte b/src/components/dataset-browser/dataset-browser.view.svelte
index a11b7c3e..3ac2d002 100644
--- a/src/components/dataset-browser/dataset-browser.view.svelte
+++ b/src/components/dataset-browser/dataset-browser.view.svelte
@@ -171,7 +171,6 @@
       }
     });
   });
-
 </script>
 
 <svelte:window on:keydown={handleKeydown} on:keyup={handleKeyup} />
@@ -250,11 +249,10 @@
   .browser-class-body img {
     width: 60px;
     box-sizing: content-box;
-    @apply border-2 border-transparent rounded-md;
+    @apply border-solid border-2 border-transparent rounded-md;
   }
 
   .browser-class-body img.selected {
-    @apply border-teal-700;
+    @apply border-gray-600;
   }
-
 </style>

From 4fbeed002c1cc74f8cf44a8ee8d36b7501e2d7ba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jules=20Franc=CC=A7oise?= <me@julesfrancoise.com>
Date: Tue, 12 Oct 2021 14:51:20 +0200
Subject: [PATCH 4/6] Fix Typescript warning

---
 src/components/training-history/training-history.component.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/components/training-history/training-history.component.ts b/src/components/training-history/training-history.component.ts
index 1d25d62d..82346c06 100644
--- a/src/components/training-history/training-history.component.ts
+++ b/src/components/training-history/training-history.component.ts
@@ -44,6 +44,7 @@ export class TrainingHistory<InputType, OutputType> extends Component {
   constructor(public dataStore: DataStore, options: TrainingHistoryOptions = {}) {
     super();
     this.options = { ...defaultOptions, ...options };
+    this.lock = this.lock.then(noop);
     this.start();
     this.ready = this.ready
       .then(() => this.dataStore.connect())

From 121f6e7a87d74dd173a992478eb3478d411371aa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jules=20Franc=CC=A7oise?= <me@julesfrancoise.com>
Date: Tue, 12 Oct 2021 16:03:05 +0200
Subject: [PATCH 5/6] Fix table pagination

---
 src/ui/components/Select.svelte             |  2 +-
 src/ui/components/TableFooter.svelte        | 39 +++++++++++++++++----
 src/ui/components/table-array-provider.ts   |  1 +
 src/ui/components/table-service-provider.ts |  1 +
 4 files changed, 35 insertions(+), 8 deletions(-)

diff --git a/src/ui/components/Select.svelte b/src/ui/components/Select.svelte
index a32de3e7..27a0537a 100644
--- a/src/ui/components/Select.svelte
+++ b/src/ui/components/Select.svelte
@@ -17,7 +17,7 @@
     on:change={(e) => dispatch('change', e.target.value)}
   >
     {#if placeholder}
-      <option value="">{placeholder}</option>
+      <option value="" disabled>{placeholder}</option>
     {/if}
     {#each options as option}
       <option value={option}>{option}</option>
diff --git a/src/ui/components/TableFooter.svelte b/src/ui/components/TableFooter.svelte
index 44aed183..8054c32e 100644
--- a/src/ui/components/TableFooter.svelte
+++ b/src/ui/components/TableFooter.svelte
@@ -1,23 +1,48 @@
 <script lang="ts">
   import type { Action } from './table-types';
-  import { get } from 'svelte/store';
   import Button from './Button.svelte';
   import Select from './Select.svelte';
   import { TableDataProvider } from './table-abstract-provider';
   import TableActions from './TableActions.svelte';
+  import { noop } from '../../utils/misc';
 
   export let provider: TableDataProvider;
   export let actions: Action[];
   export let selected: number[];
 
-  $: total = provider.total;
+  // $: total = provider.total;
   $: itemsPerPage = provider.options.itemsPerPage;
 
   let page = 1;
+  let numPages = 1;
+  let start = 0;
+  let end = 0;
+  let total = 0;
+  let unsub = noop;
 
-  $: numPages = Math.ceil($total / itemsPerPage);
-  $: start = (page - 1) * itemsPerPage + 1;
-  $: end = Math.min($total, page * itemsPerPage);
+  $: {
+    unsub();
+    unsub = provider.total.subscribe((t) => {
+      if (t === undefined || t === 0) {
+        numPages = 1;
+        start = 0;
+        end = 0;
+        total = 0;
+      } else {
+        numPages = Math.ceil(total / itemsPerPage);
+        start = (page - 1) * itemsPerPage + 1;
+        end = Math.min(total || 0, page * itemsPerPage);
+        total = t;
+      }
+    });
+  }
+
+  // $: console.log('provider', provider);
+  // $: console.log('total', total);
+  // $: console.log('$total', $total);
+  // $: numPages = $total ? Math.ceil($total / itemsPerPage) : 1;
+  // $: start = $total ? (page - 1) * itemsPerPage + 1 : 0;
+  // $: end = Math.min($total || 0, page * itemsPerPage);
 
   function gotoPage(i: number): void {
     page = i;
@@ -41,7 +66,7 @@
           options={['10', '20', '50', 'all']}
           value={itemsPerPage.toString()}
           on:change={({ detail }) => {
-            const n = detail === 'all' ? get(total) : parseInt(detail);
+            const n = detail === 'all' ? total : parseInt(detail);
             provider.paginate(n);
             itemsPerPage = n;
           }}
@@ -49,7 +74,7 @@
       </div>
     </div>
     <div class="mx-3">
-      {start}-{end} of {$total}
+      {start}-{end} of {total}
     </div>
     <Button
       round
diff --git a/src/ui/components/table-array-provider.ts b/src/ui/components/table-array-provider.ts
index 58a5a90d..435586f7 100644
--- a/src/ui/components/table-array-provider.ts
+++ b/src/ui/components/table-array-provider.ts
@@ -7,6 +7,7 @@ export class TableArrayProvider<T extends Record<string, unknown>> extends Table
   constructor({ data, ...options }: TableProviderOptions & { data: Array<T> }) {
     super(options);
     this.rawData = data;
+    this.total.set(data.length);
     this.data.set(this.rawData.slice(0, this.options.itemsPerPage));
   }
 
diff --git a/src/ui/components/table-service-provider.ts b/src/ui/components/table-service-provider.ts
index 26d7a3a0..a820e6ff 100644
--- a/src/ui/components/table-service-provider.ts
+++ b/src/ui/components/table-service-provider.ts
@@ -66,6 +66,7 @@ export class TableServiceProvider<
       });
       this.data.set(data);
       this.total.set(res.total);
+      console.log('res.total', res.total);
       this.error.set(null);
     } catch (error) {
       this.data.set([]);

From e7227d5c3dc9a7ebecc7f713d15d0a19e7d9f470 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jules=20Franc=CC=A7oise?= <me@julesfrancoise.com>
Date: Tue, 12 Oct 2021 16:21:08 +0200
Subject: [PATCH 6/6] Update version and changelog

---
 CHANGELOG.md | 4 ++++
 package.json | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 35cf9368..8407105b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Marcelle changelog
 
+## 0.4.4
+
+- Various minor bugfixes
+
 ## 0.4.3
 
 - Fixed svelte component compilation (reverted to svelte v3.39)
diff --git a/package.json b/package.json
index 395c3660..094e3d18 100644
--- a/package.json
+++ b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@marcellejs/core",
   "description": "Marcelle Core API",
-  "version": "0.4.3",
+  "version": "0.4.4",
   "repository": {
     "type": "git",
     "url": "https://github.com/marcellejs/marcelle"