org-pomodoro-short-break-finished shouldn't clock-out when org-pomodoro-clock-break is t

[sineau]

Hello,
I was trying this:
(setq org-pomodoro-clock-break t)
to have my break time counted in. But realized that we have this on org-pomodoro-short-break-finished:

(when org-pomodoro-clock-break
    (org-clock-out nil t))

I'm very new to Elisp, and maybe mistaken, but shouldn't this be unless?

[jtoloe]

If you have org-pomodoro-clock-break set to t, org-pomodoro won't clock out when the short break starts. This statement ensures that it is clocked out when the break is finished.

[jtoloe]

So the title of the issue is wrong. If you want to clock the break, clocking out should be done when the break finishes, not before. If what you actually want is to not clock out at all, I don't think that behavior is supported at the moment. I came here because I was looking for that behavior and couldn't find it.