Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thanks for writing the post! it's extremely solid :D #9

Open
jasikpark opened this issue Jan 13, 2022 · 3 comments
Open

thanks for writing the post! it's extremely solid :D #9

jasikpark opened this issue Jan 13, 2022 · 3 comments

Comments

@jasikpark
Copy link

This isn't the right place, but I wanted to point out that your code blocks have their overflow hidden on the bevy tutorial post:

image

thanks for writing the post! I especially appreciate the "see the diff" asides that let me know whether I'm on track with your tutorial!

@marcusbuffett
Copy link
Owner

Thanks for the kind words! Especially about the “see the diff” bits, those are very annoying to update so I’m glad they’re appreciated 😄.

The overflow thing is expected afaict, it’s scrollable right? I guess I could make the text wrap, but that looks a bit uglier IMO. What I can do is run these code blocks through rustfmt, with a small max_width, like 60 chars or something. I’ll do that, but lmk if that doesn’t sound right to you as a fix

@jasikpark
Copy link
Author

Yeah, I'm a bit confused b/c it seems that scrolling isn't working for me - I eventually set "width:max-content" on the containing div... I'm not sure what's up with it.

Also I feel you on the "updating the diffs" standpoint b/c there was one or two diffs linked to in the blog post that didn't seem to contain the right changes

@jasikpark
Copy link
Author

Maybe https://github.com/tummychow/git-absorb would be useful for you trying to edit git history easily?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants