Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'RNSkInfoParameter.h' file not found with Firestore at IOS #59

Open
blueromans opened this issue Oct 23, 2024 · 15 comments · May be fixed by #60
Open

'RNSkInfoParameter.h' file not found with Firestore at IOS #59

blueromans opened this issue Oct 23, 2024 · 15 comments · May be fixed by #60

Comments

@blueromans
Copy link

Description

Im getting 'RNSkInfoParameter.h' file not found error when I try to use with Firestore. I tried difficult version combination however I couldn't build. Current version 1.5.0 and react-native-skottie: 2.1.4

Version

2.1.4

Steps to reproduce

Add firestore and react-native-skottie to project

Snack, code example, screenshot, or link to a repository

"dependencies": {
   "@openspacelabs/react-native-zoomable-view": "^2.1.6",
   "@react-native-community/datetimepicker": "^8.2.0",
   "@react-native-firebase/app": "^21.2.0",
   "@react-native-firebase/firestore": "^21.2.0",
   "@react-native-firebase/messaging": "^21.2.0",
   "@react-native-masked-view/masked-view": "^0.3.0",
   "@react-navigation/bottom-tabs": "^6.6.1",
   "@react-navigation/native": "^6.1.9",
   "@react-navigation/stack": "^6.3.20",
   "@reduxjs/toolkit": "^2.2.8",
   "@sentry/react-native": "^5.33.2",
   "@shopify/flash-list": "^1.7.1",
   "@shopify/react-native-skia": "^1.5.0",
   "@tanstack/react-query": "^5.8.9",
   "date-fns": "^4.1.0",
   "i18next": "^23.7.7",
   "ky": "^1.1.3",
   "react": "^18.3.1",
   "react-hook-form": "^7.53.0",
   "react-i18next": "^13.5.0",
   "react-native": "^0.75.4",
   "react-native-alert-notification": "^0.4.0",
   "react-native-device-info": "^13.1.0",
   "react-native-element-dropdown": "^2.12.2",
   "react-native-gesture-handler": "^2.14.0",
   "react-native-image-picker": "^7.1.2",
   "react-native-keyboard-aware-scroll-view": "^0.9.5",
   "react-native-mmkv": "2.11.0",
   "react-native-modal-datetime-picker": "^18.0.0",
   "react-native-pager-view": "^6.4.1",
   "react-native-reanimated": "3.15.5",
   "react-native-safe-area-context": "^4.7.4",
   "react-native-screens": "^3.27.0",
   "react-native-skottie": "^2.1.4",
   "react-native-svg": "^15.8.0",
   "react-native-vector-icons": "^10.2.0",
   "react-native-video": "^6.7.0",
   "react-native-video-controls": "^2.8.1",
   "react-redux": "^9.1.2",
   "redux": "^5.0.1",
   "redux-persist": "^6.0.0"
 },

Podfile

pod 'FirebaseCore', :modular_headers => true
pod 'GoogleUtilities', :modular_headers => true
pod 'FirebaseCoreExtension', :modular_headers => true
pod 'FirebaseFirestoreInternal', :modular_headers => true
@PrinceUBS
Copy link

+1

@PrinceUBS
Copy link

Screenshot 2024-10-23 at 5 59 09 PM

@PrinceUBS
Copy link

Facing same issue on Android as well.

i have enabled
def enableProguardInReleaseBuilds = true

but also added following rule in proguard-rules.pro:

# for skia, if you haven't add it
-keep class com.shopify.reactnative.skia.** { *; }

# for skottie
-keep class com.skiaskottie.** { *; }
Screenshot 2024-10-24 at 10 27 59 AM

If you have any ideas, @hannojg and @mrousavy , please share them with us.

@redbluenat
Copy link

+1

1 similar comment
@max-moonward
Copy link

+1

@JimTeva
Copy link

JimTeva commented Nov 4, 2024

For others: the fix is to remove/comment the line 15 of file node_modules/react-native-skottie/cpp/RNSkSkottieView.h: #include "RNSkInfoParameter.h"
(For the moment I recommend doing a patch-package until the PR is approved)

@FilipiRafael
Copy link

FilipiRafael commented Nov 12, 2024

For others: the fix is to remove/comment the line 15 of file node_modules/react-native-skottie/cpp/RNSkSkottieView.h: #include "RNSkInfoParameter.h" (For the moment I recommend doing a patch-package until the PR is approved)

Hey @JimTeva, I did it, but it didn't solve the issue, after deleting that one line, it's now appearing another build error:

Screenshot 2024-11-12 at 10 02 29

I also confirmed that my file is the same as this one: https://github.com/margelo/react-native-skottie/blob/953aee408e60e0c735fe011dfc85aba727ba5987/package/cpp/RNSkSkottieView.h

I also tried to build the app with Xcode 15.4 instead of 16.1, but I got the same errors.

FYI, I did the patch package correctly, rebuilt the app, and cleaned the cache, but it still has this error. Do you know what it could be?

@FilipiRafael
Copy link

@JimTeva, actually, in my case, it was only a cache problem, I solved it after deleting the ios/Pods and ios/build, thanks 🤝

@p-sebastian
Copy link

@FilipiRafael what skia version are you running? looks the above screenshot you posted keeps appearing any time the #include "RNSkInfoParameter.h is removed

@FilipiRafael
Copy link

@p-sebastian I'm using the 1.5.3. As I said before, I solved it after deleting the ios/Pods and ios/build

@gustavobarca
Copy link

Facing the same issue too. I've tried downgrading the version, removing the ios/Pods and ios/Buid folders and also deleting the line 15 of the file node_modules/react-native-skottie/cpp/RNSkSkottieView.h, but nothing worked. The issue remains the same. Any ideas?

@FilipiRafael
Copy link

hey @gustavobarca, you could clean the Xcode Derived Data folder as well, it may help. Also, if you already did the patch-package, you can delete the node_modules folder, then install it again and then try build it.

@p-sebastian
Copy link

the issue was the skia version. Will only work up to skia 1.5.3, after that it breaks.

@ejkkan
Copy link

ejkkan commented Dec 4, 2024

Also seeing this!

@blueromans
Copy link
Author

blueromans commented Dec 4, 2024

Also seeing this!

could you try this?
cd ios && rm -rf Pods/ && rm Podfile.lock && pod install && cd .. && watchman watch-del-all && yarn start --reset-cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants