Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to pymarian tests #95

Open
snukky opened this issue Jun 27, 2024 · 2 comments
Open

Improvements to pymarian tests #95

snukky opened this issue Jun 27, 2024 · 2 comments

Comments

@snukky
Copy link
Member

snukky commented Jun 27, 2024

Proposed improvements:

  1. Log "Using Python: " when running run_mrt.sh with a path and python version.
  2. Log "Using pymarian: ".
  3. Let overwrite the Python binary similarly to providing marian binary, for example PYTHONBIN=python3 run_mrt.sh
  4. In tests/pymarian/setup.sh consider the case when multiple .whl files are present in marian's build/ directory and instead of failing, maybe pick just the first one.
  5. The pymarian test should not fail due to not being able to download the licensed COMET-Kiwi model. I believe we can split test_pymarian.sh into 2 .sh test files: (1) one running COMET-Kiwi unit tests, which will be skipped if the model cannot be downloaded and 2) the other running all other unit tests.
@snukky
Copy link
Member Author

snukky commented Jun 27, 2024

The motivation for 5. is that one may not be able to download that model in automatic testing.

@snukky
Copy link
Member Author

snukky commented Jun 27, 2024

FYI, @thammegowda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant