-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different SDF Samples than DeepSDF. #41
Comments
I think DeepSDF specifies the noise variance while the parameter in this repo is specified using standard deviation. You should take the square root to compare. |
@philippwulff May I ask how you scaled the standard deviation in the code? |
@dqj5182 It's been a while, but I remember that there Is a line pretty deep down in the source code that you need to modify for that. |
@philippwulff Thanks for the reply! Would the code you mentioned be this part?
|
No, you need to find the code that samples locations. I couldn’t find it just now, but it is there somewhere. |
Have you found the part that affects the sampling position? I have tested some places, and the sampling point is still close to 0 |
Hi, I looked into this library as an alternative for the mesh2sdf preprocessing pipeline in DeepSDF and I noticed that this library chooses the SDF sample location much closer to the boundary than the algorithm in DeepSDF. Why is that? Is it deliberate and does't this have negative results on training DeepSDF style models, since the sampling locations x,y,z are smaller values and therefore more difficult to learn for a network?
Let me show an example:
Loading a preprocessed shape from DeepSDF and converting a mesh to an SDF via this library:
As you can see, the SDF values given by this library are much closer to zero than with the DeepSDF tool.
Rendering the SDF values smaller than 0 from
mesh_to_sdf
:Rendering the SDF values smaller than 0 from DeepSDF's preprocessing pipeline:
I looked at the for choosing the sampling locations in this library and in the DeepSDF code and it looked almost identical. I only think, that
mesh_to_sdf
uses a twice as large variance (even though this difference seems to require much than justx2
). I also looked at other examples and what I found is not unique.The text was updated successfully, but these errors were encountered: