Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same contract can be added by differents users #38

Open
quentin-burg opened this issue Jan 5, 2024 · 0 comments
Open

Same contract can be added by differents users #38

quentin-burg opened this issue Jan 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@quentin-burg
Copy link
Collaborator

quentin-burg commented Jan 5, 2024

Current behavior:

  • Contract address must be unique inside the Gas Station. So when a user add a contract, anybody cannot add the same contract.
  • Users who want to add a contract that already exists have no information about this contract and in particular about the reason for refusal, which can be disturbing.

Behavior wanted

  • Contracts may be added several times into Gas Station only if the owner is different (user A cannot add the same contract twice) => the couple (user ID * contract address) must be unique.
  • Entrypoints can be enable or disabled depending on the user (=user A wants to enable entrypoint 1 while user B wants to enable entrypoint 2).
  • Priority is given to the vault with the most credits.
  • If a called entrypoint is deactivated, we will check whether an active entrypoint exists for the same contract for a different user. The credits needed to pay for the transaction will then be taken from the vault for that user.

Related to #21 (comment)

@quentin-burg quentin-burg added the enhancement New feature or request label Jan 5, 2024
@quentin-burg quentin-burg changed the title IMPROVMENT: Same contract can be added by differents users Same contract can be added by differents users Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant