Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos found while adapting the chapter 2 tutorial #8

Closed
pglewis opened this issue Jan 20, 2016 · 2 comments
Closed

Typos found while adapting the chapter 2 tutorial #8

pglewis opened this issue Jan 20, 2016 · 2 comments

Comments

@pglewis
Copy link

pglewis commented Jan 20, 2016

https://marionette.gitbooks.io/marionette-guides/content/en/getting_started/tutorial/layouts.html

Near the end in layout.js onChildviewAddTodoItem still refers to this.ui, but the ui has been refactored out into the form view at this point. To get this to work I needed to add a parameter to the onChildviewAddTodoItem method and access ui via that object.

This also appears in the summary code:

https://marionette.gitbooks.io/marionette-guides/content/en/appendix/getting_started/tutorial/todo_app.html

@jdaudier
Copy link
Contributor

/cc @scott-w

@pglewis
Copy link
Author

pglewis commented Jan 20, 2016

scott-w added a commit to scott-w/guides that referenced this issue Jan 23, 2016
Thanks to @pglewis for pointing these out.
scott-w added a commit to scott-w/guides that referenced this issue Jan 23, 2016
jdaudier added a commit that referenced this issue Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants