Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildFlags for -race #15

Open
flibustenet opened this issue Jul 1, 2017 · 5 comments
Open

BuildFlags for -race #15

flibustenet opened this issue Jul 1, 2017 · 5 comments

Comments

@flibustenet
Copy link
Contributor

I would like to build with -race flag (or any other).

Thanks !

@markbates
Copy link
Owner

A PR would definitely be welcome! :)

@flibustenet
Copy link
Contributor Author

flibustenet commented Jul 1, 2017

Then, do you think -i and -v should be kept in the code or in the config file by default ? -race should be by default also isn't it ?

build_target_path: ""
build_path: /tmp
build_delay: 200ns
build_flags: [-v, -i, -race]
binary_name: refresh-build

@markbates
Copy link
Owner

I think -v and -i should definitely be defaults. Here's what I think. I think we should add a build_flags to the config. If it's present it those flags should be used. If it's not present, then a default of -i and -v should be used, which is the current behavior.

@flibustenet
Copy link
Contributor Author

I think it's better if they are explicit in the config file and by default written with init
If not it's ambiguous if build_flags: [] will be different as nothing (don't know if I'm clear)
I mean I just need to add BuildFlags: []string{"-v", "-i", "-race"}, in init.go
A PR will be easier to see...

@markbates
Copy link
Owner

I think it's fine to write them into the config when running init, I think that's the right choice. However, I want to maintain backward compatibility. There are a lot of config files out there that don't have build_flags in them. So keep the functionality consistent if there build_flags isn't in the config then we should continue to use -v -i as default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants