Trips up on field named reference

[alex-tan]

CREATE TABLE example_table (
  reference character varying
)

line 2: ERROR: syntax error at or near "reference"

[markdrago]

This is a fun one. Apparently there is a set of keywords that are only used by ecpg, which is the tool used by pgsanity to actually verify that the SQL is valid. You can see the full list of these reserved words here:

https://github.com/postgres/postgres/blob/master/src/interfaces/ecpg/preproc/ecpg_kwlist.h

I suspect we would see similar problems with the other keywords in that list (eg descriptor, section, identified, etc.). While it should be possible for pgsanity to obfuscate these keywords before sending them through to ecpg (ie convert 'reference' to 'ecpgkw_reference' before validation), pgsanity would ideally also deobfuscate any error messages that come back from ecpg such that the original token is shown to the user instead of the obfuscated one.

[alex-tan]

Ah interesting. I did a quick search in this codebase but I figured it would probably be in a dependency somewhere.