Some moves towards UI isolation #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om TextFilterManager
…rmanager # Conflicts: # Razor/UI/Razor.cs
…vergence # Conflicts: # Razor/UI/Razor.cs
…rgence # Conflicts: # Razor/UI/Razor.cs
…ence # Conflicts: # Razor/UI/Razor.cs
jaedan
reviewed
Sep 10, 2021
|
I have written a RunUO gump script that fairly well emulates a tabbed interface. It's a bit huge and knobby because of the constraints of gumps, but I would happily share the code and some screenshots if it will help. |
|
If I can get Razor building on my system I might also port the idea to Razor just to contribute. Looking for detailed build instructions on Linux if anyone has them. Or command line (I don't have Visual Studio) instructions for Windows 10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to jumpstart decoupling the Razor's functional guts from WinForms specifically and UI side of things in general.
Why bother?
Running headless, making an alternative UI in case MS kicks WF to the curb; @markdwags mentioned ditching it all in favour of gump-based UI, which would be absolutely wicked.
Mixing UI code with engine guts in a global static object managing a pile of its own instances effectively kills any prospect of unit/automated testing, aside from causing a literal headache if meditated upon for long enough.
What's in?
Not much compared to the whole workload necessary to run headless, but I hope it's a start.
Dragged some UI code from obviously domain stuff:
On WinForms front:
Fencing off some of the MessageBox calls behind a separate class — far from complete, but it's mostly straightforward, will do a more extensive overhaul in a separate PR;Same for most clipboard calls except ones that deal with images — will have to take a better look af them.What's next?
Specific plans are part 1, parts 2 & 3 are more in the vague far-off milestones department for now.