Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for KMS server-side encryption? #39

Open
zezke opened this issue May 8, 2017 · 2 comments
Open

Support for KMS server-side encryption? #39

zezke opened this issue May 8, 2017 · 2 comments

Comments

@zezke
Copy link

zezke commented May 8, 2017

I've made some changes to support KMS encryption. You can just provide a kmsKeyId and it'll set everything up.

Is this interesting enough to warrant a PR?

@kileynaromw
Copy link

Hi zezke! Your request appears to be a bit different at first glance, but you may be interested in the PR I opened back on May 20th:

#41

Having this PR merged would allow me as a caller to say something like:

backup = new DynamoBackup({
    ...,
    ServerSideEncryption = 'AES256'
});

It looks like your request KMS encryption is a bit different because my ServerSideEncryption change above uses a default key on the server, but I thought I'd mention it.

@dylanlingelbach
Copy link
Collaborator

@zezke yes, this warrants a PR. I lost my write permissions to this repo so trying to figure out if I need to move it. It may take me a while to merge a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants