Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_dicom_from_oct fails when patient's name contains ä, ö, å etc #148

Open
tomi-lilja opened this issue Sep 12, 2024 · 2 comments
Open

Comments

@tomi-lilja
Copy link

Hi,

When using create_dicom_from_oct, the following AttributeError occurs seemingly when there are characters like ä or ö in patient's name:

dcm = create_dicom_from_oct(f)
File "D:\Python\Lib\site-packages\oct_converter\dicom\dicom.py", line 413, in create_dicom_from_oct
files = create_dicom_from_e2e(input_file, output_dir, extract_scan_repeats)
File "D:\Python\Lib\site-packages\oct_converter\dicom\dicom.py", line 489, in create_dicom_from_e2e
fundus_images = e2e.read_fundus_image(extract_scan_repeats=extract_scan_repeats)
File "D:\Python\Lib\site-packages\oct_converter\readers\e2e.py", line 395, in read_fundus_image
patient_id=self.patient_id,
AttributeError: 'E2E' object has no attribute 'patient_id'

I was wondering if there's a way to handle these characters, too?

BR,

Tomi

@marksgraham
Copy link
Owner

Hi Tomi,

If you're able to send a scan with this problem I might be able to take a look!

Best,
Mark

@tomi-lilja
Copy link
Author

Sure, here you can download a test patient e2e file with "ä" and "ö" in patient's name, which generates the error:
https://drive.google.com/drive/folders/1f6KPmLL_eFmHpk4TeKxs0GB_iPvv15_7

BR,

Tomi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants