Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasheet download fails #2

Closed
jj-uk opened this issue Mar 28, 2024 · 9 comments
Closed

Datasheet download fails #2

jj-uk opened this issue Mar 28, 2024 · 9 comments

Comments

@jj-uk
Copy link

jj-uk commented Mar 28, 2024

Downloading of datasheets doesn't seem to work. When opening the PDF in a text editor, it looks like the contents are a webpage copy, not a PDF.

@markusdd
Copy link
Owner

Please share the contents you see and the part url or number you used

@jj-uk
Copy link
Author

jj-uk commented Mar 28, 2024

Part # C473012, but all parts I've tried have the same issue. Generated (downloaded) PDF attached (open in a text editor).

2304140030_Espressif-Systems-ESP32-WROOM-32D-N4_C473012.pdf

@markusdd
Copy link
Owner

that is extremely odd. will look into that as soon as possible, this looks a bit as if something has changed on their end.

@markusdd
Copy link
Owner

ok, found the problem.

the JSON URL now points to a split screen page with parts info on right and the PDF to the left.
I need to patch this URL in order for the PDF to be downloaded.

The release pipeline for 1.3.0 is currently running. Once that is available, can you please test?

@markusdd
Copy link
Owner

Release is now available: https://github.com/markusdd/EasyEDA_to_KiCAD_Lib_UI/releases/tag/v1.3.0

Please provide feedback and close when fixed. (FYI: you might need to delete the broken PDFs first, it will not override them as I've noticed, but that's a fix for a later day^^)

@sinalco92
Copy link

Datasheets will be download in the library folder. But in the KiCad Symbol Properties there is a Random Online Link (only for C5441281) to a different datasheets not the download in the library folder. Is its possible to link to the local folder or directly to the data sheet link that are in your link (https://www.lcsc.com/datasheet/). In the symbol library there is from https://item.szlcsc.com/ and everything is on china (I test with V1.3).

@jj-uk
Copy link
Author

jj-uk commented Mar 29, 2024

#C473012

Thanks for the update. Datasheets are now being downloaded into the downloads folder.

However, @sinalco92 points out another bug:

In the *.kicad_sym file, property "Datasheet" is incorrect link, e.g.

(property "Datasheet" "https://item.szlcsc.com/549848.html" (id 3) (at -2.286 0.127 0)

default_lib.zip

@markusdd
Copy link
Owner

Hi, this bug needs to be raised seperately at JLC2KiCAD lib, which this project is built on.
I do not interfere with the generation of the symbol files, so please raise an issue over there.

@jj-uk
Copy link
Author

jj-uk commented Mar 29, 2024

@sinalco92 I've opened an issue for this over on the TousstNicolas/JLC2KiCad_lib repo:

TousstNicolas/JLC2KiCad_lib#70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants