Add easy borrow form #421
Merged
Add easy borrow form #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Size Report
|
|
it wasn't communicated anywhere but can you add mobile view as well? it available on mobile navbar figma |
|
|
||
| export function Connector({ className }: ConnectorProps) { | ||
| return ( | ||
| <svg className={className} preserveAspectRatio="xMidYMid meet" viewBox="0 0 84 93" fill="none"> |
There was a problem hiding this comment.
I think that should be exported as separate icon from assets
There was a problem hiding this comment.
Yeah, you can put this in assets and then import it as a component like this: import Icon from '@/ui/assets/icon.svg?react'
| @@ -34,4 +34,8 @@ const panelVariants = cva('rounded-sm', { | |||
| m: 'p-3 md:p-8 sm:p-5', | |||
| }, | |||
| }, | |||
| defaultVariants: { | |||
| variant: 'primary', | |||
| spacing: 'm', | |||
There was a problem hiding this comment.
Can you take a look at this PR Panel change? In current implementation we are missing white background panels which by design seems to be the primary ones. That PR will be kept as draft for a while so can we add something like this in here? That will reduce amount of possible regressions later on
There was a problem hiding this comment.
@EmilMalanczak bg-primary is white, bg-primary-inverse is black. I don't think we need to change color variants for panel component. Let's keep it simple for now.
oskarvu
approved these changes
Nov 7, 2024
|
|
||
| export function Connector({ className }: ConnectorProps) { | ||
| return ( | ||
| <svg className={className} preserveAspectRatio="xMidYMid meet" viewBox="0 0 84 93" fill="none"> |
There was a problem hiding this comment.
Yeah, you can put this in assets and then import it as a component like this: import Icon from '@/ui/assets/icon.svg?react'
EmilMalanczak
approved these changes
Nov 7, 2024
oskarvu
added a commit
that referenced
this pull request
Nov 11, 2024
* Add some css variables * Update config colors (#386) * Add typography utilities * Add gradients to tailwind theme * Add new Button component (#387) * Add new switch component (#389) * Add switch * Put pseudo classes up front so addon is working correctly * Improve stories * Auto accept changes for redesign feature branch * Fix typo * Do not display hover state when disabled * Change storybook tsconfig alias (#392) * Use different alias for storybook config * Use better alias * Add IconBox component (#390) * Add stories ui helper * Add IconBox component * Simplify button stories * Simplify component api * Move story helper component * Add .storybook folder to tailwind config content prop * Add select component (#388) * Add TopbarNavigation (#391) * add topbar page icons * add pages colors * update SavingsAPYBadge * add Topbar Button * add TopbarNavigation * add TopbarNavigation stories * adjust DropdownMenu styles * adjust icons whitespaces * move into 'new' folder * add opened dropdown stories * Add new alert component (#394) * Add alert component * Prevent story from cutting out in chromatic * Add New Tooltip (#393) * add Tooltip * add global min size decorator * add rounded arrow * adjust global decorator styles * Add AssetInput component (#395) * Refactor tailwind config colors (#396) * Move border and background specific colors config to its own properties * Fix switch colors regression * Adjust classes after rebasing * Update switch style (#397) * Add new health factor indicator (#398) * Add new ltv slider component (#401) * Add transaction overview building blocks (#402) Co-authored-by: Oskar <[email protected]> * Remove postfix and prefix icons from button props (#400) * Remove postfix and prefix icons from button props * Add icon button stories * Add margin to icon when only child * Add IconButton --------- Co-authored-by: Emil Małańczak <[email protected]> * Redesign actions row and grid (#403) * Extract actions grid component * Rewrite action rows to use updated row components * Improve action row components simplicity of use * Improve styles and handle mobile * Fix easy borrow page tests * Add index and icon basic transitions * PR comments * Explicitly set variant and size for button * Improve grid gap handling * Update colors after rebasing * Add remove button to input (#406) * Add new panel component (#408) * Restyle upgrade savings dai banner (#409) * Update upgrade savings banner * Add router decorator * add TopbarWallet (#404) * add useClipboard utility * add CopyButton * update primary button gradient * update wallet icons * add TopbarWalletDropdown * add TopbarWallet * remove unused code * rename ConnectedButton * update wallet icons * add ButtonIcon className support * change IconButton * add DropdownMenuItemIcon * adjust TopbarWallet implementation * remove exit sandbox from dropdown * remove read-only mode leftover * remove ephemeral info from wallet dropdown * add TopbarMenu (#410) * add DropdownMenuContent variants * add TopbarMenu * add TopbarMenu stories * pass build info as prop * Update savings token card styles (#412) * Update styles for savings token panels * Add test id to savings token panel * Support mobile view * Redesign transaction overview (#411) * Adjust old nav components (#413) * add TopbarNetwork * update chain icons * fix topbar navigation dropdown chevron * add brand logo icons * adjust network button icon * update old navbar components * adjust topbar network component * fix chromatic dropdown issues * adjust storybook global styles * assemble Topbar (#415) * assemble topbar * update airdrop button icon * hide rewards and airdrop content on smaller screen * Add savings opportunity connected and guest modes (#416) * Add savings opportunity connected and guest modes * Add savings opportunity panel test id * Add test id to savings rate * Display chain related tokens at opportunity panel * Update stories * Handle no cash case nicer * Use new inputs in dialogs (#414) * Update actions panel styles (#417) * Update dialog switch panels (#418) * Update dialog switch panels * Use same bg for both switch panels * Adjust dialog container style (#420) * Adjust dialog styles wip * Update dialog styles * Use new alert component * Add testids to alert and simplify * Add fullscreen layout to actions stories * Add testid to dialog close button * Improve settings dialog styles * Display settings drawer in dialog * Fix action view stories * Fix tests * Add black bg to image so it doesn't flash significantly while loading * update AppLayout (#419) * update AppLayout * update NotSupportedWarning * add layout background * disable migration banner feature flag * change wrong topbar backdrop * shrink layout max width * update all pages layouts * make topbar accessible on not supported view * Update savings welcome dialog (#422) * Add new welcome dialog * Improve bg handling * Add easy borrow form (#421) * Replace buttons across the app (#427) * Delete old button component * Replace buttons across the app * Update address input styles (#424) * Update icon pack * Update address input styles * Use link button instead of link decorator * Add router decorator to savings withdraw story * Update link component (#425) * Add glow to tooltip so its visible when on dark bg * Update link style * Exterminate sloppiness * Update easy borrow side panel (#426) * Redesign and refactor success views (#429) * Redesign and refactor success views * Adjust styles a bit * Adjust tests * Replace panels with new component (#430) * Replace panels with new component * Handle stablecoins in wallet case * Improve market details typography * Remove spacing from upgrade banner * Use headers in places where panel titles were used * Use section component for panel wrapping element * Add Mobile Topbar UI (#431) * add MenuItem * adjust Dialog bottom variant * update SelectNetworkDialog * update SandboxDialog * add mobile TopbarWallet * add mobile TopbarMenu * add mobile TopbarNavigation * fix savings apy badge * adjust layout padding * fix stories * fix stories * small adjustments * extract activePathGroup into hook * cleanup navigation logic * Add my wallet chart (#432) * add new tabs (#434) * add new tabs * fix single chart panel * remove compact layout (#435) * update page meta images (#437) * New connect wallet cta (#433) * Add new wallet connect cta panel * Fix market details tests * Replace farms icon (#439) * My portfolio layout (#436) * add redesign top banner (#438) * add redesign top banner * fix naming * fix close button active styles * Adjust banner style --------- Co-authored-by: oskarvu <[email protected]> * Change markets summary icons (#442) * Update style for market summary tiles * Add backdrop blur to make text more readable * Final ui updates (#440) * update FarmsView * update favicon * adjust table styles * update farms views * lint fix * adjust farms view headers * update farms skeletons * update skeletons * Improve skeletons and other things * Fix chart layout scaling bug * Use proper favicon --------- Co-authored-by: oskarvu <[email protected]> * Add base network configuration (#441) * Add staked in farm tx overview row (#443) * Route min height * Bring back ltv slider to mobile view --------- Co-authored-by: Emil Małańczak <[email protected]> Co-authored-by: oskarvu <[email protected]> Co-authored-by: Oskar <[email protected]> Co-authored-by: Emil Małańczak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.