Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is not raised if any of the approval request fail to send #16

Open
marshall7m opened this issue Aug 20, 2022 · 0 comments
Open

Error is not raised if any of the approval request fail to send #16

marshall7m opened this issue Aug 20, 2022 · 0 comments
Labels
bug Something isn't working priority

Comments

@marshall7m
Copy link
Owner

Within the approval request Lambda Function, the function doesn't raise an exception if any of the approval requests fail to send via AWS SES. Currently, the function just returns a status code 500 with a count of failed sends and quietly passes the error return value within the execution but doesn't bring it to the user's attention via any downstream states. With the error passed as a return value, this doesn't allow for exception catching within the Step Function definition to possibly notify the user's that they should update any invalid approval voter email addresses.

@marshall7m marshall7m added the bug Something isn't working label Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
Development

No branches or pull requests

1 participant