From 1054dcbed74e9bc52b1af7da5af25a3ef3388467 Mon Sep 17 00:00:00 2001 From: Morgan Aubert <morgan@aubert.email> Date: Sat, 30 Apr 2022 22:16:35 -0400 Subject: [PATCH] Update temporary table names used for the migrations runner specs --- .../db/management/migrations/runner_spec.cr | 34 +++++++++---------- .../migrations/202108092226111_auto.cr | 2 +- .../bar_app/migrations/202108092226112.cr | 2 +- .../migrations/202108092226111_auto.cr | 2 +- .../migrations/202108092226112_auto.cr | 2 +- .../migrations/202108092226113_auto.cr | 2 +- 6 files changed, 22 insertions(+), 22 deletions(-) diff --git a/spec/marten/db/management/migrations/runner_spec.cr b/spec/marten/db/management/migrations/runner_spec.cr index 1daa70562..b945749c8 100644 --- a/spec/marten/db/management/migrations/runner_spec.cr +++ b/spec/marten/db/management/migrations/runner_spec.cr @@ -17,8 +17,8 @@ describe Marten::DB::Management::Migrations::Runner do introspector = Marten::DB::Connection.default.introspector Marten::DB::Management::SchemaEditor.run_for(Marten::DB::Connection.default) do |schema_editor| - schema_editor.delete_table("foo_tags") if introspector.table_names.includes?("foo_tags") - schema_editor.delete_table("bar_tags") if introspector.table_names.includes?("bar_tags") + schema_editor.delete_table("runner_spec_foo_tags") if introspector.table_names.includes?("runner_spec_foo_tags") + schema_editor.delete_table("runner_spec_bar_tags") if introspector.table_names.includes?("runner_spec_bar_tags") end # Reset local migration app configs to avoid them to be used elsewhere. @@ -34,8 +34,8 @@ describe Marten::DB::Management::Migrations::Runner do introspector = Marten::DB::Connection.default.introspector Marten::DB::Management::SchemaEditor.run_for(Marten::DB::Connection.default) do |schema_editor| - schema_editor.delete_table("foo_tags") if introspector.table_names.includes?("foo_tags") - schema_editor.delete_table("bar_tags") if introspector.table_names.includes?("bar_tags") + schema_editor.delete_table("runner_spec_foo_tags") if introspector.table_names.includes?("runner_spec_foo_tags") + schema_editor.delete_table("runner_spec_bar_tags") if introspector.table_names.includes?("runner_spec_bar_tags") end end @@ -61,12 +61,12 @@ describe Marten::DB::Management::Migrations::Runner do introspector = Marten::DB::Connection.default.introspector - introspector.table_names.includes?("foo_tags").should be_true - columns_details = introspector.columns_details("foo_tags") + introspector.table_names.includes?("runner_spec_foo_tags").should be_true + columns_details = introspector.columns_details("runner_spec_foo_tags") columns_details.map(&.name).sort!.should eq ["active", "id", "label"] - introspector.table_names.includes?("bar_tags").should be_true - columns_details = introspector.columns_details("bar_tags") + introspector.table_names.includes?("runner_spec_bar_tags").should be_true + columns_details = introspector.columns_details("runner_spec_bar_tags") columns_details.map(&.name).sort!.should eq ["active", "id", "label"] end @@ -86,8 +86,8 @@ describe Marten::DB::Management::Migrations::Runner do introspector = Marten::DB::Connection.default.introspector - introspector.table_names.includes?("bar_tags").should be_true - columns_details = introspector.columns_details("bar_tags") + introspector.table_names.includes?("runner_spec_bar_tags").should be_true + columns_details = introspector.columns_details("runner_spec_bar_tags") columns_details.map(&.name).sort!.should eq ["id", "label"] end @@ -112,8 +112,8 @@ describe Marten::DB::Management::Migrations::Runner do introspector = Marten::DB::Connection.default.introspector - introspector.table_names.includes?("foo_tags").should be_false - introspector.table_names.includes?("bar_tags").should be_false + introspector.table_names.includes?("runner_spec_foo_tags").should be_false + introspector.table_names.includes?("runner_spec_bar_tags").should be_false end it "is able to fake a specific migration forward" do @@ -133,7 +133,7 @@ describe Marten::DB::Management::Migrations::Runner do introspector = Marten::DB::Connection.default.introspector - introspector.table_names.includes?("bar_tags").should be_false + introspector.table_names.includes?("runner_spec_bar_tags").should be_false end it "marks replacement migrations as applied if the replaced migrations were applied during the runner execution" do @@ -147,7 +147,7 @@ describe Marten::DB::Management::Migrations::Runner do introspector = Marten::DB::Connection.default.introspector - introspector.table_names.includes?("foo_tags").should be_true + introspector.table_names.includes?("runner_spec_foo_tags").should be_true end it "marks replacement migrations as applied if the replaced migrations were applied before the runner execution" do @@ -191,7 +191,7 @@ describe Marten::DB::Management::Migrations::Runner do introspector = Marten::DB::Connection.default.introspector - introspector.table_names.includes?("bar_tags").should be_false + introspector.table_names.includes?("runner_spec_bar_tags").should be_false end it "is able to unapply the migrations of a specific app up to a specific version" do @@ -212,8 +212,8 @@ describe Marten::DB::Management::Migrations::Runner do introspector = Marten::DB::Connection.default.introspector - introspector.table_names.includes?("bar_tags").should be_true - columns_details = introspector.columns_details("bar_tags") + introspector.table_names.includes?("runner_spec_bar_tags").should be_true + columns_details = introspector.columns_details("runner_spec_bar_tags") columns_details.map(&.name).sort!.should eq ["id", "label"] end end diff --git a/spec/marten/db/management/migrations/runner_spec/bar_app/migrations/202108092226111_auto.cr b/spec/marten/db/management/migrations/runner_spec/bar_app/migrations/202108092226111_auto.cr index f2ee22028..0102d9678 100644 --- a/spec/marten/db/management/migrations/runner_spec/bar_app/migrations/202108092226111_auto.cr +++ b/spec/marten/db/management/migrations/runner_spec/bar_app/migrations/202108092226111_auto.cr @@ -2,7 +2,7 @@ class Migration::RunnerSpec::BarApp::V202108092226111 < Marten::Migration depends_on "runner_spec_foo_app", "202108092226111_auto" def plan - create_table :bar_tags do + create_table :runner_spec_bar_tags do column :id, :big_int, primary_key: true, auto: true column :label, :string, max_size: 255, unique: true end diff --git a/spec/marten/db/management/migrations/runner_spec/bar_app/migrations/202108092226112.cr b/spec/marten/db/management/migrations/runner_spec/bar_app/migrations/202108092226112.cr index 3a38ea579..bf473ae55 100644 --- a/spec/marten/db/management/migrations/runner_spec/bar_app/migrations/202108092226112.cr +++ b/spec/marten/db/management/migrations/runner_spec/bar_app/migrations/202108092226112.cr @@ -2,6 +2,6 @@ class Migration::RunnerSpec::BarApp::V202108092226112 < Marten::Migration depends_on "runner_spec_bar_app", "202108092226111_auto" def plan - add_column :bar_tags, :active, :bool, default: true + add_column :runner_spec_bar_tags, :active, :bool, default: true end end diff --git a/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226111_auto.cr b/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226111_auto.cr index dc500e1ca..ea2fb0481 100644 --- a/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226111_auto.cr +++ b/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226111_auto.cr @@ -1,6 +1,6 @@ class Migration::RunnerSpec::FooApp::V202108092226111 < Marten::Migration def plan - create_table :foo_tags do + create_table :runner_spec_foo_tags do column :id, :big_int, primary_key: true, auto: true column :label, :string, max_size: 255, unique: true end diff --git a/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226112_auto.cr b/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226112_auto.cr index 3df84932a..f4b5a2f66 100644 --- a/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226112_auto.cr +++ b/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226112_auto.cr @@ -2,6 +2,6 @@ class Migration::RunnerSpec::FooApp::V202108092226112 < Marten::Migration depends_on "runner_spec_foo_app", "202108092226111_auto" def plan - add_column :foo_tags, :active, :bool, default: true + add_column :runner_spec_foo_tags, :active, :bool, default: true end end diff --git a/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226113_auto.cr b/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226113_auto.cr index a99524074..27d8b365c 100644 --- a/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226113_auto.cr +++ b/spec/marten/db/management/migrations/runner_spec/foo_app/migrations/202108092226113_auto.cr @@ -3,7 +3,7 @@ class Migration::RunnerSpec::FooApp::V202108092226113 < Marten::Migration replaces "runner_spec_foo_app", "202108092226112_auto" def plan - create_table :foo_tags do + create_table :runner_spec_foo_tags do column :id, :big_int, primary_key: true, auto: true column :label, :string, max_size: 255, unique: true column :active, :bool, default: true