Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inplace update of jacobians #9

Closed
martinjrobins opened this issue Mar 24, 2024 · 0 comments · Fixed by #40
Closed

inplace update of jacobians #9

martinjrobins opened this issue Mar 24, 2024 · 0 comments · Fixed by #40
Assignees
Labels
optimisation improves the efficiency of the solvers

Comments

@martinjrobins
Copy link
Owner

martinjrobins commented Mar 24, 2024

the NonLinearOp and LinearOp have a jacobian function which returns a matrix

fn jacobian(&self, x: &Self::V, t: Self::T) -> Self::M

This requires creating a new matrix everytime the jacobian is recalculated. Need an "inplace" version that can update an existing jacobian.

This will require additions to the Matrix trait to allow for mutation of existing matrices

related to #6 and #7

@martinjrobins martinjrobins added the enhancement New feature or request label Mar 24, 2024
@martinjrobins martinjrobins added optimisation improves the efficiency of the solvers and removed enhancement New feature or request labels Apr 20, 2024
@martinjrobins martinjrobins self-assigned this Apr 21, 2024
martinjrobins added a commit that referenced this issue Apr 21, 2024
martinjrobins added a commit that referenced this issue Apr 28, 2024
martinjrobins added a commit that referenced this issue Apr 29, 2024
martinjrobins added a commit that referenced this issue Apr 30, 2024
martinjrobins added a commit that referenced this issue Apr 30, 2024
martinjrobins added a commit that referenced this issue Apr 30, 2024
martinjrobins added a commit that referenced this issue May 1, 2024
martinjrobins added a commit that referenced this issue May 1, 2024
martinjrobins added a commit that referenced this issue May 1, 2024
martinjrobins added a commit that referenced this issue May 2, 2024
martinjrobins added a commit that referenced this issue May 2, 2024
martinjrobins added a commit that referenced this issue May 2, 2024
martinjrobins added a commit that referenced this issue May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimisation improves the efficiency of the solvers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant