Faer dense matrix #21
Conversation
|
Tomorrow will rebase the branch and try to reuse as much code as I can using macros |
|
This should close #7 |
…Scale<f64> for Mul, This will require further modifications in all the impl of Matrix
|
@martinjrobins Please check this PR, here we are adding support for Faer's dense matrix representation. All tests are passing, the code is rebased and I collapsed the arithmetic implementations of for Matrix and Vector as much as I could using Macros. I also fixed an error in one of the macros for Sundials |
|
great, thanks @Siel. I've just had a quick glance and will have a proper look later. quick question: I notice that all the faer types use |
|
Sure, I can do it |
|
@martinjrobins Done |
There was a problem hiding this comment.
great stuff, thanks @Siel. Minor changes, plus I think that From<faer::Scale> should be implemented for Scale<T> to neaten up the code
Implementation of the
Matrixtrait using the dense matrix representation in faer.Tests are passing.
In order to get a fully working example we might need to generalize the
LUstruct