Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 workaround for this issue #25

Merged
merged 4 commits into from
Apr 4, 2024
Merged

#3 workaround for this issue #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d4fd4d
#3 workaround for this issue
martinjrobins Apr 4, 2024
1d0864c
#3 turn on ci for beta and nightly
martinjrobins Apr 4, 2024
3bd5404
#3 reduce number of runners
martinjrobins Apr 4, 2024
161b5ec
#3 make sure we have clippy
martinjrobins Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,15 @@ jobs:
matrix:
toolchain:
- stable
#- beta
#- nightly
os:
- ubuntu-latest
- macos-latest
- windows-latest
include:
- toolchain: beta
os: ubuntu-latest
- toolchain: nightly
os: ubuntu-latest

steps:
- uses: actions/checkout@v4
Expand All @@ -46,7 +49,7 @@ jobs:
target
key: unit-test-${{ runner.os }}-${{ matrix.toolchain}}
- name: Set up Rust
run: rustup default ${{ matrix.toolchain }} && rustup update ${{ matrix.toolchain }} --no-self-update
run: rustup default ${{ matrix.toolchain }} && rustup update ${{ matrix.toolchain }} --no-self-update && rustup component add clippy
- name: Rust version
run: rustc -Vv
- name: Install LLVM and Clang
Expand Down
6 changes: 4 additions & 2 deletions src/vector/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,10 @@ pub trait VectorView<'a>:
pub trait Vector:
VectorOpsByValue<Self>
+ for<'b> VectorOpsByValue<&'b Self>
+ for<'a> VectorOpsByValue<Self::View<'a>>
+ for<'a, 'b> VectorOpsByValue<&'b Self::View<'a>>
// TODO: commenting out these because they cause a compiler hang (https://github.com/martinjrobins/diffsol/issues/3)
// TODO: replace when this is fixed
//+ for<'a> VectorOpsByValue<Self::View<'a>>
//+ for<'a, 'b> VectorOpsByValue<&'b Self::View<'a>>
+ Mul<Scale<Self::T>, Output = Self>
+ Div<Scale<Self::T>, Output = Self>
+ VectorMutOpsByValue<Self>
Expand Down
Loading