Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing return on Android does not move cursor to new line. #79

Closed
martinstoeckli opened this issue Jan 9, 2021 · 7 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@martinstoeckli
Copy link
Owner

martinstoeckli commented Jan 9, 2021

On some Android devices, when pressing the cursor does not move to the next line, even if a new line was added to the text. This behaviour started end of 2020 after an update of the GBoard app.

@martinstoeckli martinstoeckli self-assigned this Jan 9, 2021
@martinstoeckli martinstoeckli pinned this issue Jan 9, 2021
@martinstoeckli
Copy link
Owner Author

Seems it is a combination of the WebView component and the Android Gboard. Only on Android 10 with standard keyboard.

@martinstoeckli
Copy link
Owner Author

martinstoeckli commented Jan 18, 2021

The problem can be reproduced if a "normal" character is the last character before the cursor, as soon as there is special character like a space or comma, the line break works as expected. The same I can reproduce not only with the Quill editor, the problem also exists e.g. with the slate editor.

The problem does not happen with alternative keyboards, but those do not always use IME composition. It seems that after the event.keyCode === 229, there is no following keydown event with the newline.

@martinstoeckli
Copy link
Owner Author

Filed an issue on: https://issuetracker.google.com/issues/177757645

@gitzila
Copy link

gitzila commented Jul 25, 2021

Also happens with Android 11, webview 91.0.4472.164 (447216434) and gboard 10.8.06.382062350-beta-arm64-v8a (60781002).

@martinstoeckli martinstoeckli added the bug Something isn't working label Dec 5, 2021
@martinstoeckli
Copy link
Owner Author

martinstoeckli commented Feb 23, 2022

I'm currently trying to replace the editor with ProseMirror, which can work around this issue. It doesn't look as Google would fix this issue any time soon and ProseMirror will also allow to implement more features like tables and seems to be more future proof in general.

The work is done in the branch feture/prose-mirror.

@martinstoeckli
Copy link
Owner Author

This issue is solved in version 7.0.0. SilentNotes is now based on ProseMirror which can handle the keyboard events correctly.

@martinstoeckli
Copy link
Owner Author

It seems that Google also has fixed the issue on Jan 2023, see https://issuetracker.google.com/issues/177757645#comment21

@martinstoeckli martinstoeckli unpinned this issue Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants