Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard formatter #318

Open
martinsumner opened this issue Sep 15, 2020 · 5 comments
Open

Use standard formatter #318

martinsumner opened this issue Sep 15, 2020 · 5 comments

Comments

@martinsumner
Copy link
Owner

Apply a standard formatter to the code e.g. erlfmt

@martinsumner
Copy link
Owner Author

@ioolkos
Copy link

ioolkos commented Sep 19, 2020

@martinsumner I was looking for some bigger project doing this :)
Thinking of using erlfmt too for VerneMQ. Seems you didn't have any issues so far?

@martinsumner
Copy link
Owner Author

It just worked straight away, although I have one line which is now not showing as covered by rebar3 cover, and I can't work out why.

It is such a big change in terms of git blame though, given that this project doesn't have a lot of external participation I'm not sure it is worth merging in the PR. I'm going to think about it for a few days, perhaps I just need to get used to the opinionated formatting - at the moment I'm not finding it easier to read.

@michalmuskala
Copy link

michalmuskala commented Sep 27, 2020

I accidentally stumbled upon this issue while looking at leveled. One thing that helps with big diffs is new option introduced in git 2.23 --ignore-rev and --ignore-revs-file that allows blame to skip over some specific commit - it works great locally, but its integration with various tools (like github) is rather patchy at the moment. It's used by some big projects, nonetheless, like clang.

@ioolkos
Copy link

ioolkos commented Sep 28, 2020

@michalmuskala thanks, I didn't even know this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants