-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub: Missing redesigned code file view on Waterfox Classic (non-e10s) #94
Comments
Waterfox is not a supported platform. I may consider pull requests, but only if somebody wants to volunteer for maintenance. Waterfox-classic doesn't have class fields, and I don't suspect it ever will... |
I have tested the throw everything including the kitchen sink fix. Get https://unpkg.com/@babel/standalone/babel.min.js or https://unpkg.com/@babel/standalone/babel.js In my case I have been tweaking the original Polly extension, which works well for this so I can easily turn the Babel's tower monster on/off. I renamed it Polly2 so its settings doesn't interfere with the Polly that came with Waterfox. Try it out: https://github.com/CeruleanSky/Polly2/releases/tag/v2.0 Check the pollyfills/Babel/babel.min.js box in Polly2 probably the regenerator as well. Brew some tea and while you wait for everything to stop loading and for it to recompile everything. Most github pages take between 2 minutes to 5 minutes depending on the page. Be amazed it works! Immediately turn it back off until somebody figures out a better quicker way, such as just recompiling a whitelist of scripts using the incompatible ways like vendors-node_modules_primer_react_lib-esm_ActionMenu_ActionMenu_js & vendors-node_modules_github_file-attachment-element_dist_index_js-node_modules_primer_view-co , or maybe figuring out just the subset of babel needed for this, I got the bundle which does everything and is overkill. Unfortunately I am not too familiar with this aspect of javascript much less browser compatibility, Polly2 is just the result of incrementally trying mainly non working things over time. I think https://github.com/facebook/regenerator/blob/main/packages/transform/src/replaceShorthandObjectMethod.js this is the code that is actually fixing things up, but I don't know how to make it stand alone to find out. Also you probably have to |
Thanks to @martok for your clarification and to @CeruleanSky for your constructive contribution on the topic. I opened the GitHub support ticket #2390102 on Oct 20, 2023 to clarify the still-claimed service mechanism for browsers without Public Class Fields support, which appears to no longer be working. Unfortunately, Babel does not seem to be able to transform scripts of several hundred KB in size, inline scripts, or most ES modules - such as those used on Waterfox.net - on the fly. For my part, I already use the uBlock Origin and NoScript extensions to reduce the security risk with Waterfox Classic. Additionally, Container Tabs, URLVoid.com via Flagfox and in some cases Sandboxie Plus. But thanks for pointing that out. |
The [GitHub Feature Support Table](https://github.github.com/browser-support) shows no warning signs when dom.webcomponents.enabled is set to true.
Web Console output
https://github.githubassets.com/assets/vendors-node_modules_github_file-attachment-element_dist_index_js-node_modules_primer_view-co-2c6968-d14fe7eeba42.js
https://github.githubassets.com/assets/vendors-node_modules_primer_react_lib-esm_ActionMenu_ActionMenu_js-2f08ef908241.js
The text was updated successfully, but these errors were encountered: