Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept entry without affiliation #60

Open
jcolomb opened this issue Jul 13, 2021 · 2 comments
Open

accept entry without affiliation #60

jcolomb opened this issue Jul 13, 2021 · 2 comments

Comments

@jcolomb
Copy link
Collaborator

jcolomb commented Jul 13, 2021

sometimes only looking at contribution statement, so not needing the affiliation.
Change from error to warnings when there is no affiliation

@marton-balazs-kovacs
Copy link
Owner

You are right! This is a big topic and we should definitely review the validation function. Changes have to be made on several fronts regarding the validation. This is one of them. Another would be being more permissive with the column names. If we want to make affiliations not necessary we have to include a display logic so the outputs that require this info are disabled. I plan to functionalize the display logic part better so it would be easy to change and upgrade them. Let's make this a high priority for the next release.

@alexholcombe
Copy link
Contributor

In conversation today, Marton and I agreed to have the app "degrade gracefullly" with degenerate input, in that it would still provide outputs (as even partial outputs are useful for some use cases, so it can be somewhat irritating to users to refuse to provide an output) in almost all cases but prominently indicate warnings, and indicate missing information with NA or NULL in all-caps, written in red (except for raw-text output which doesn't allow color).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants