Pagination, Eslint & Context refactor #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyRy79261
changed the title
RyRy79261
changed the title
martriay
requested changes
Jun 27, 2021
There was a problem hiding this comment.
Thank you very much for this PR! We're in good track. I left several comments.
- This looks more like 3 PRs (Pagination, Eslit, Context refactor), please send three separate ones next time
- The build is not passing:
9:33:10 AM: Error occurred prerendering page "/Home". Read more: https://nextjs.org/docs/messages/prerender-error
9:33:10 AM: Error: useBundleData must be used within a BundleDataProvider
9:33:10 AM: at useBundleData (/opt/build/repo/.next/server/chunks/952.js:202:11)
Co-authored-by: Martín Triay <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
RyRy79261
added
the
Status: Do Not Merge 🛑
|
There seems to be an issue between the CSS being served when running There are tailwind classes that aren't being included in the build css despite being used in the markup, I suspect that tailwind might have a treeshaking build step that might be missing the additional modules though still need to validate that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7
This PR additionally refactors business logic into two context hooks, one pertaining to Bundles & Tokens
The idea is that since bundles are clusters of blocks, token flow data & any nested block related data, that it would be managed there.
Consuming or interpreting transactions, tokens, balances or balance related events would be managed in the tokens context
Additionally components have been broken out into smaller
.tsxcomponents.To make better use of the context hook data being accessable throughout the app, a move towards TS interfaces for data has been made.Functionally nothing has changed other than some logic for sniffing out if there are more bundles to paginate through
Improvement notes
A simple, can next page, approach has been taken but loading multiple pages and reducing calls can be improved from here