Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

become_user unset? #5

Closed
giovannipizzi opened this issue Jul 5, 2019 · 3 comments
Closed

become_user unset? #5

giovannipizzi opened this issue Jul 5, 2019 · 3 comments

Comments

@giovannipizzi
Copy link

Shouldn't there be a become_user: "{{ root_user }}" inside the first task of the role (and a definition of this in the defaults/main.yml? This is there in the role for Wannier90 but not here, and if I try to run this role from (an earlier version of) the Quantum Mobile (modified from 19.03) this role fails because it does not become root but it remains max.

Before changing, though, I'd like to understand better how it works (also because I'm using an older QMobile version - btw, shouldn't we pin the versions of the roles rather than use 'master'? If I now want to rebuild an old version of Quantum Mobile, I would anyway get the most recent roles, which is not what we want, right?)

@ltalirz
Copy link
Member

ltalirz commented Jul 5, 2019

We're currently in a transition phase, where I'm moving away entirely from the become_user for "simulation code roles" (step 1 here: marvel-nccr/quantum-mobile#96)

The develop branch already uses fixed versions: https://github.com/marvel-nccr/quantum-mobile/blob/develop/requirements.yml

@ltalirz
Copy link
Member

ltalirz commented Jul 5, 2019

Just to mention also that I'm bumping the major version number for this transition, i.e. v0.1.2 of the quantumespresso role still has the become_user

@giovannipizzi
Copy link
Author

ok thanks, so I'll close this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants