Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding pseudopotentials #3

Closed
ltalirz opened this issue Dec 6, 2019 · 22 comments
Closed

consider adding pseudopotentials #3

ltalirz opened this issue Dec 6, 2019 · 22 comments

Comments

@ltalirz
Copy link
Member

ltalirz commented Dec 6, 2019

@bosonie We're including a couple of pseudopotentials for Quantum Espresso in Quantum Mobile (since they don't ship with the code).
How is it for Siesta, are a set of standard PPs already included?
If not, can you point me to a zip that I should download?

@bosonie
Copy link
Contributor

bosonie commented Dec 7, 2019

Hi Leopold. I'm not sure I understood what you mean. With the code we ship few pseudopotentials (PPs) that can be used in the examples we provide. If you, instead, refer to an entire set of PPs with certified accuracy, the situation is much more complected.

@ltalirz
Copy link
Member Author

ltalirz commented Dec 7, 2019

Yes - I mean a set of pseudopotentials for the periodic table (like the SSSP or the SG15 ONCV).
Consider someone downloads the Quantum Mobile and wants to do some Siesta calculations for their system - how can we provide something they can use to get started?

@bosonie
Copy link
Contributor

bosonie commented Dec 8, 2019

Ok, here the situation is complicated. Siesta is moving to the use of PPs in psml format (PseudoDojo project), however there is still no official release of Siesta that supports psml.
If you see in the siesta repository (https://gitlab.com/siesta-project/siesta - btw, siesta is now on GitLab, no more on launchpad, you might think to change the link in the README), the psml-support branch is still on its own, not included in any release.
Give me few days to ask Alberto what is the time-line for the next release and if he feels to include some other PPs. When are you planning to release the new virtual machine? I suppose in February before the school at CINECA...or before?

@ltalirz
Copy link
Member Author

ltalirz commented Dec 8, 2019

btw, siesta is now on GitLab, no more on launchpad, you might think to change the link in the README

thanks, will do!

Give me few days to ask Alberto what is the time-line for the next release and if he feels to include some other PPs.

Ok - by the way, my question is just about including pps in Quantum Mobile, not necessarily with siesta (in case this was not clear).

When are you planning to release the new virtual machine? I suppose in February before the school at CINECA...or before?

I'll definitely make a pre-release soon (this week) but there may be another one with slight updates later.

@bosonie
Copy link
Contributor

bosonie commented Dec 12, 2019

Dear Leopold,
with Alberto we agreed that it makes sense to include some PPs only if we are also allowed to include an additional version of Siesta in quantum-mobile. A version that supports psml. Is it possible?? Your opinion?

@ltalirz
Copy link
Member Author

ltalirz commented Dec 12, 2019

it makes sense to include some PPs only if we are also allowed to include an additional version of Siesta in quantum-mobile. A version that supports psml. Is it possible?? Your opinion?

Does Siesta only support either one format or the other? How about including an executable that supports both?

Another question: should I be using the latest siesta release MaX-1.0 in the QE release for this week, i.e. is it a "stable" release?
I usually include only stable releases but I could also make an exception as we're including the latest "MaX" releases from all the other codes as well, so I'm basically just looking for your preference.

@bosonie
Copy link
Contributor

bosonie commented Dec 12, 2019

The release MaX-1.0 supports both psml and psf PPs, therefore is going to be the one of choice in the future (with another name I guess). However it is not a "stable" release at the moment. It is not entirely tested as far as I understood. We remembered the policy to include only stable versions, therefore our idea was to include that version (that has all the new features - spin-orbit, +U, constrained DFT, psml, ...), but maybe also leave a more stable release. If you don't mind to have a not super "stable" version, we can go with just MaX-1.0. If we go that way, there are some dependences to take care of (new version of libxc and psml library in particular). I can ask Alberto to provide more info about it tailored to the distribution you have in the virtual machine.

@ltalirz
Copy link
Member Author

ltalirz commented Dec 12, 2019

If you don't mind to have a not super "stable" version, we can go with just MaX-1.0.

This version of Quantum Mobile will anyhow be a release candidate pre-release, so that seems fine to me.

If we go that way, there are some dependences to take care of (new version of libxc and psml library in particular). I can ask Alberto to provide more info about it tailored to the distribution you have in the virtual machine.

That would be very helpful. You find the current recipe I use here:
https://github.com/marvel-nccr/ansible-role-siesta/blob/master/tasks/main.yml
(the basics should be human readable, even if you're not familiar with ansible)

@bosonie
Copy link
Contributor

bosonie commented Dec 12, 2019

Great, we will prepare something to facilitate you the installation.
And also we prepare PPs libraries to ship. For this I need to ask you what was the choice of SSSP. LDA, PBE? both? Efficiency? Precision? Thanks

@ltalirz
Copy link
Member Author

ltalirz commented Dec 12, 2019

and this is the arch file: https://github.com/marvel-nccr/ansible-role-siesta/blob/master/templates/arch.make.deb_or_ubuntu

It currently fails with

 -I. -I/usr/lib/openmpi/include     -I../ -DMPI -DFC_HAVE_FLUSH -DFC_HAVE_ABORT -DCDF -DGRID_DP -DPHI_GRID_SP  /tmp/siesta-MaX-1.0/Src/fdf/fdf.F90
    ar  cru libfdf.a \
                    iso_fortran_env.o fdf.o io_fdf.o parse.o utils.o prec.o
    echo libfdf.a
    libfdf.a
    cp libfdf.a ..
    make[1]: Leaving directory '/tmp/siesta-MaX-1.0/Obj/fdf'

    SIESTA: dc_lapack.a has been deprecated in favor of:
      COMP_LIBS += libsiestaLAPACK.a
    Please update your arch.make file accordingly...

    Makefile:416: recipe for target 'dc_lapack.a' failed
  stdout_lines: <omitted>

Feel free to make a PR (it will actually run the build on docker) or to just write instructions here in the issue.

what was the choice of SSSP. LDA, PBE? both? Efficiency? Precision? Thanks

We have the PBE SSSP, both efficiency and precision versions.

@bosonie
Copy link
Contributor

bosonie commented Dec 12, 2019

Ok, thanks! Yes I sent all the links to Alberto, we will formalise the necessary steps to get through the installation.

@albgar
Copy link
Collaborator

albgar commented Dec 13, 2019

Hi @ltalirz: I am preparing full instructions to compile the MaX release of Siesta. There are a number of new dependencies, but I am managing to automatize it. You will just need to translate the steps to ansible-speak. I guess you need this for today?

@ltalirz
Copy link
Member Author

ltalirz commented Dec 13, 2019

thanks @albgar !

Yes, if I could get it some point today that would be great - I will do the QM release on the weekend.

@bosonie
Copy link
Contributor

bosonie commented Dec 15, 2019

Dear Leopold,
I wanted to reach the PseudoDojo people before passing to you the repositories. Just for political correctness. They gave me the green light. As I can't attach here the .tgz repo, I will send them directly by email to you. They are Norm Conserving Scalar relativistic PBE (NC SR ONCVPSP v0.4 in the PseudoDojo website). Both stnadard and stringent set.
Please make sure to acknowledge PseudoDojo, a reference to the web-site is sufficient. Thanks!

@albgar
Copy link
Collaborator

albgar commented Dec 15, 2019

@ltalirz
Copy link
Member Author

ltalirz commented Dec 15, 2019

thanks, I've incorporated the pseudopotentials in the role - attribution information is provided in the automatically generated release_notes.txt on the desktop.

Note: the ansible role now points to the URLs posted above, i.e. please let me know in case you want to change them at some point.
If you are looking for a long-term URI to publish them, consider posting them on zenodo.org or archive.materialscloud.org

As for the updated siesta version, I've had a stab at incorporating the scripts but it is taking me too long in order to finish the QM release today.
I.e. I'll release an RC1 today and we'll incorporate the latest siesta version in the next release.
Thanks a lot for your help!

@bosonie
Copy link
Contributor

bosonie commented Jul 8, 2020

Hi @ltalirz and @albgar ,
I find myself back to this issue because I started to look at the new quantum mobile.
At the end the new version of siesta was never included, right? I think Alberto sent the instruction to Leopold but they were never implemented...
This is a bit unfortunate because in the aiida_siesta we implemented a part that works only with the new Siesta-MaX release (that supports psml pseudopotential).
Can we make sure to have the new Siesta version in the next release?

@bosonie
Copy link
Contributor

bosonie commented Jul 8, 2020

Dear @ltalirz, Alberto just informed me that, at the end, a choice was made to not move to the Max version of Siesta. The set of instruction for this version is still lacking. I guess we will target September to have it ready.
Sorry for bothering you.

@ltalirz
Copy link
Member Author

ltalirz commented Jul 8, 2020

no worries, let me know when you are ready!

@albgar
Copy link
Collaborator

albgar commented Nov 29, 2020

I guess that this issue can be closed now. There is an update to the ansible role for the MaX-1.1 version, and psml pseudopotential sets are included.

@chrisjsewell
Copy link
Member

yep I will close. Although perhaps there should also be some automation for having these psuedopotentials loaded into aiida.

Currently, quantum-espresso pseudo families are loaded here: https://github.com/marvel-nccr/ansible-role-aiida/blob/master/tasks/aiida-pps.yml,
but I'm sure there is a way to make this a bit more "generic", possibly via https://github.com/aiidateam/aiida-pseudo

@chrisjsewell
Copy link
Member

chrisjsewell commented Dec 6, 2020

Moved the last point to marvel-nccr/ansible-role-aiida#63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants