Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno compatibility issue #4

Closed
kjloveless opened this issue Oct 27, 2024 · 0 comments
Closed

deno compatibility issue #4

kjloveless opened this issue Oct 27, 2024 · 0 comments

Comments

@kjloveless
Copy link

hi mary, feel free to close this if you don't intend to support deno.
figured i'd raise it just in case though..

on the line i referenced below you use window.addEventListener, the problem is that window was removed from deno.

window.addEventListener('storage', listener, { signal });

i was able to change it to globalThis locally, and things seemed to work.
looks like globalThis has pretty good support:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis#browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis

i didn't review the code super carefully, so i apologize if i missed something!
thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant