clean up javascript

Author: wjwwood

js/login.js

@@ -18,7 +18,9 @@ $( document ).ready(function() {
     // If found, pass the temp token to gatekeeper
     if (match) {
         var code = match[1];
-        $.getJSON('http://auth.design.ros2.org/authenticate/' + code, function(data) {
+        // var gatekeeper_domain = 'desolate-shelf-7303.herokuapp.com';  // for local testing
+        var gatekeeper_domain = 'auth.design.ros2.org';
+        $.getJSON('http://' + gatekeeper_domain + '/authenticate/' + code, function(data) {
             // Once gatekeeper gets back, check for the token
             if (!data.token) {
                 // If the token is not set, then display an error

js/ros2-design.js

@@ -86,7 +86,10 @@ $( document ).ready(function() {
                        '    <h3 class="panel-title">Error</h3>',
                        '  </div>',
                        '  <div class="panel-body">',
-                       '    Error retrieving Github Info: ' + err,
+                       '    Error retrieving Github Info: <br/>',
+                       '    [' + err.request.status + '] ' +
+                       err.request.statusText + '<br/>',
+                       '    ' + err.request.response,
                        '  </div>',
                        '</div>'].join('\n'));
                 } else {
@@ -159,7 +162,7 @@ $( document ).ready(function() {
         // Define function for handling a single issue
         var check_issue = function(prs_in, index) {
             // If index >= the length of the issues originally given, exit
-            if (index >= prs_in.length) {
+            if (!prs_in || index >= prs_in.length) {
                 return;
             }
             // Else grab the current issue