Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change data exposed over IPC to type other than Newtonsoft JObject #98

Open
lichie567 opened this issue Jul 19, 2024 · 2 comments
Open

Comments

@lichie567
Copy link

Currently the json being exposed to other plugins via IPC is exposed as a JObject type from the newtonsoft library, which blocks (or significantly hinders) use of any other json parsing library in plugins consuming the data.

@marzent
Copy link
Owner

marzent commented Jul 19, 2024

Which datatype do you think would make more sense?

@marzent
Copy link
Owner

marzent commented Jul 20, 2024

Just to add a bit more context, OverlayPlugin uses heavily Newtonsoft and I try very hard to maintain source compatibility with them as much as possible...
So in any case the data that is generated will be a newtonsoft JObject and passing that around is the most efficient approach (this works doubly well since Dalamud provides the newtonsoft reference and I heard there are basically no plans to move from it away in the near future).
But am open to changing the API surface here if it is too inconvenient, since LMeter is the only consumer here I know of anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants