Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please separate self.callKitCenter.incomingCall function into a separate one? #15

Open
tuanngotechnical opened this issue Sep 24, 2020 · 5 comments
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@tuanngotechnical
Copy link

tuanngotechnical commented Sep 24, 2020

Could you please separate this function into a separate one? So it is possible to customize the incoming screen when the foreground and backgroud should be displayed.

File: flutter_ios_voip_kit/ios/Classes/VoIPCenter.swift

Line 85 and line 106:

self.callKitCenter.incomingCall(uuidString: info?["uuid"] as! String,
callerId: info?["incoming_caller_id"] as! String,
callerName: callerName).

Currently, i cannot disable default incoming of CallKit when app run at foreground.

z2092876646901_7fb83aa8c32e4e734066f27601e9aa32

@ghenry
Copy link

ghenry commented Oct 4, 2020

I see you forked this project and just released a new package on pub.dev

How come you didn't just do a PR to this project? Now there are two projects on pub.dev with only ony function in difference. Seems pointless....

@masashi-sutou masashi-sutou added the invalid This doesn't seem right label Oct 6, 2020
@masashi-sutou
Copy link
Owner

masashi-sutou commented Oct 6, 2020

@tuanngotechnical

I have confirmed the commit you created.

Why do I need to call the incomingCall method without VoIP notifications?

And instead of publishing to pub.dev, specify the branch or fork it on pubspec.yaml.

dependencies:
  flutter_ios_voip_kit:
    git:
      url: [email protected]:tuanngotechnical/flutter_ios_voip_kit.git

@masashi-sutou masashi-sutou added the wontfix This will not be worked on label Oct 6, 2020
@tuanngotechnical
Copy link
Author

@tuanngotechnical

I have confirmed the commit you created.

Why do I need to call the incomingCall method without VoIP notifications?

And instead of publishing to pub.dev, specify the branch or fork it on pubspec.yaml.

dependencies:
  flutter_ios_voip_kit:
    git:
      url: [email protected]:tuanngotechnical/flutter_ios_voip_kit.git

Ohh. Sorry, I dont know that.

For your question, why i need to separate a new method? Because i want to handle it in 2 state: Active and Inactive. In case inactive, app will auto handle by CallKit UI default. But when app is Active, i will show more info to users something like : caller is new customer or exists customers? have any order of this users? how many orderred? what is an issue which is processing... Theses information is very important to supporters to prepare answer before pickup the call. If you handle incoming call automatically, the app will show UI CallKit and app customize CallScreen also. Therefore, i need to move displayIncomingCall to a new method.

Thank you so much! Your code is verry helpful and i really appreciate that.

@rekonvald
Copy link

Have the same requirement! Have you solved it?

@tuanngotechnical
Copy link
Author

tuanngotechnical commented Mar 12, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants