Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep8? #22

Open
pjadzinsky opened this issue Mar 25, 2019 · 3 comments
Open

pep8? #22

pjadzinsky opened this issue Mar 25, 2019 · 3 comments
Milestone

Comments

@pjadzinsky
Copy link

pjadzinsky commented Mar 25, 2019

Any way you guys will consider pep8ing the code? The whole codebase would benefit from use of pep8 linter. Just to mention a few:

  • CamelCase methods (in contrast of not_camel_case_once) are very non pythonian.
  • expand names, abbreviations like 'te', 'it' and 'ts' should be avoided
@masfaraud
Copy link
Owner

Hi,
I agree for the abbreviations.
For the camel case, it is my own convention to distinguish methods from variable. I find this very usefull in scientific computing to know if an attribute is data or a computation.
I know it's not PEP8 compliant...

@pjadzinsky
Copy link
Author

Hi thanks for the reply
I don't want to be too pushy but a lot of thinking went into defining pep8 and it is for a reason. By having methods be camel case you are creating a confusion between methods and classes. At the same time there shouldn't be a confusion between attributes and methods because methods have parenthesis while attributes don't.

according to your style, my_moudle.This() is this a class or a method?

according to pep8
my_module.This() is always a class
my_object.this is is always an attribute of my_object
my_object.this() is always a method

I don't see how you can confuse them

@masfaraud
Copy link
Owner

Ok let's make the next version pep8 compliant.

@masfaraud masfaraud added this to the Version 0.2 milestone May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants