Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check branch types in written ROOT files #29

Closed
masonproffitt opened this issue Aug 20, 2020 · 2 comments
Closed

Check branch types in written ROOT files #29

masonproffitt opened this issue Aug 20, 2020 · 2 comments
Labels
bug Something isn't working
Milestone
v0.2

Comments

@masonproffitt
Copy link
Owner

masonproffitt commented Aug 20, 2020 •
edited
Loading

I don't think Float16_t and Double32_t are handled correctly. Should test both type and numerical limits.
@masonproffitt masonproffitt added the bug Something isn't working label Aug 20, 2020
@masonproffitt masonproffitt added this to the v0.2 milestone Aug 24, 2020
masonproffitt added a commit that referenced this issue Aug 24, 2020
@masonproffitt
test branch types #29
f27654b
masonproffitt added a commit that referenced this issue Aug 24, 2020
@masonproffitt
remove incorrectly labeled branches #29
ce3e987 
some types were not set correctly in the test file for floating point scalar branches
@masonproffitt
Copy link
Owner Author

Proper type-checking was implemented by #33 and #34

@masonproffitt
Copy link
Owner Author

New issue for testing numerical limits: #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
1 participant
@masonproffitt