Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro - replaceEntities Unicode Issue #110

Open
dazKind opened this issue May 29, 2018 · 0 comments
Open

Macro - replaceEntities Unicode Issue #110

dazKind opened this issue May 29, 2018 · 0 comments

Comments

@dazKind
Copy link

dazKind commented May 29, 2018

Im running an older Haxe and Neko version and I noticed that HtmlEntities were not correctly written by the macro. "×" was converted to "×" in the generated js-output.

I fixed it locally by adding the classic Utf8.decode in this line https://github.com/massiveinteractive/haxe-react/blob/master/src/lib/react/jsx/JsxParser.hx#L98:
if (map.exists(entity)) result += haxe.Utf8.decode(map.get(entity));

I figure latest Neko does something differently there?

Tested with:
Haxe 3.4.4
neko 2.1.0

@dazKind dazKind changed the title Macro - replaceEntities Unicode Isse Macro - replaceEntities Unicode Issue May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant