Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of inlining #9

Open
Okamoi opened this issue Sep 16, 2013 · 2 comments
Open

Make use of inlining #9

Okamoi opened this issue Sep 16, 2013 · 2 comments

Comments

@Okamoi
Copy link

Okamoi commented Sep 16, 2013

Hi,

Thanks for that simple and efficient library. Would you mind inlining all the appropriate functions ?

I would do it myself and send a pull request, but I'm afraid I may be a little heavy handed with inlining. Might as well be done by someone who fully knows how it's best used :)

Thanks either way !

@thomasuster
Copy link
Contributor

Hey @Okamoi . Inlining can be weird. I think if you inline you have to allocate more onto the stack, so I only add it if there's a very specific bottle-neck. Are you hitting a performance problem somewhere?

@Okamoi
Copy link
Author

Okamoi commented Aug 19, 2016

Not really. I just consistently see speed improvements on most code I inline with Haxe. I did notice that many good programmers use inline more sparingly than I do. I don't exactly understand why. Perhaps it's with good reason, or perhaps they come from languages with a compiler that inlines less cleverly than Haxe's.

I trust you know what's best better than I do so feel free to close the issue if you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants