-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Add svt-av1 to the --photon-noise
supported encoders
#836
Comments
That would be because mainline SVT-AV1 has only merged the photon-noise patch very recently, even though we've had access to it for more than a year in Soichiro's fork initially, then BlueSwordM's fork with some other patches and in SVT-AV1-PSY then. It should indeed be changed. |
The commit is for the fix-docs branch only - is av1an photon noise working for svt-av1 by now because it added --fgs-table? |
Looks like I forgot to update the docs when I merged in the patch to av1an to support photon noise in svt-av1. It is indeed working, only the documentation needs updated. |
Thanks for the clarification. Speaking of docs, the photon noise implementation is still a bit black-box-ish :-) and I am wondering what enabling av1an's --photon-noise does to the encoders' DE-noise settings - i.e. REEMOVING noise (svt --film-grain-denoise / aom --enable-dnl-denoising & --denoise-noise-level). The --help of svt is especially unhelpful because the description for --film-grain-denoise only refers to --film-grain, but doesn't mention --fgs-table Concerning adding noise, the doc 'the two should not be used together" is clear that photon and non-photon are mutually exclusive. |
Photon noise does not enable any of the encoder's denoising. You're right, it may make sense to add that to the documentation as well. |
The documentation currently states that
--photon-noise
is only supported by aom and rav1e, when it works fine with svt-av1 (Tested using svt-av1-psy)The text was updated successfully, but these errors were encountered: