-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move data fetching code or side effects to componentDidUpdate. #344
Comments
Yeah... Looks like it was fixed 4 months ago but never released? If you look in the ActionButton.js, you can see that the code has been updated to useEffect, but if you look at the installed version in node_modules the "componentWillReceiveProps" is still there. Hopefully someone notices eventually. |
There hasn't been a release since 2018??
Are people just cloning and using this code directly in their own projects? |
Can someone tell me how to fix this? |
So yeah the only way I "fixed" the problem was to clone the existing code, which contains the fix, and use it as a component. There is someone out there doing the pull-requests/fixes but no one doing the builds. |
Ah, now I see. Thank you. |
Warning in the console:
componentWillReceiveProps has been renamed and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.
The text was updated successfully, but these errors were encountered: