Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more modules #6

Open
17 tasks
mastilver opened this issue Jul 5, 2017 · 6 comments
Open
17 tasks

Add more modules #6

mastilver opened this issue Jul 5, 2017 · 6 comments

Comments

@mastilver
Copy link
Owner

mastilver commented Jul 5, 2017

  • redux-thunk
  • moment
  • immutable
  • jquery
  • selectize
  • picker
  • packery
  • backbone
  • underscore
  • handlebars
  • modernizr
  • crypto-js
  • raty
  • react-overlays
  • modernizr
  • redux-saga/effects
  • preact
@swyxio
Copy link

swyxio commented Feb 6, 2018

hey mastilver - seems you arent maintaining this anymore - just wondering what your thoughts are? is it not useful enough?

@mastilver
Copy link
Owner Author

Hi @sw-yx 👋

I saw your slides, really cool 👍
I'm still maintaining it, I just took a few months away from open-source
I'll slowly going through my notifications to address all the raised issue / opened PRs
In the meantime, feel free to send me a PR to add modules :)

@swyxio
Copy link

swyxio commented Feb 7, 2018

hey thanks for the reply!! I was just thinking, maybe theres a way to define a default rule for module-to-cdn to map for any arbitrary library. I don't really like this whitelisting approach because it doesn't scale. since you can define modules to exclude/include in dynamic-cdn-webpack-plugin anyway, there's no real downside.

as a further extra step, we could build in some sort of "ping" to validate the module-to-cdn result during the web pack build process. it would slow down the build but then guarantee that this autogenerated module-to-cdn mapping is valid for a particular library and version.

what do you think?

@mastilver
Copy link
Owner Author

maybe theres a way to define a default rule for module-to-cdn to map for any arbitrary library.

I wish that was possible... but not everybody is using the same pattern
If you find another solution, that would be awesome :)

we could build in some sort of "ping" to validate the module-to-cdn result during the web pack build process

Can you explain that, I didn't get it...
If library is not valid module-to-cdn should return null
Also I planning to create a module-to-cdnjs that will return a Promise (It will needs the make a api calls to check if the lib is there as a new version is available after a new version is published - do I make sense?)

@mastilver
Copy link
Owner Author

We could use https://packd.now.sh/ but I'm not sure if it's out of beta yet

@swyxio
Copy link

swyxio commented Feb 7, 2018

not sure. im not going to work on this right now as I don't have much better ideas. but I think its a really good idea that I will probably come back to in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants