Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typography styles for the navigation block #19

Open
unscripted opened this issue Oct 13, 2023 · 0 comments
Open

Remove typography styles for the navigation block #19

unscripted opened this issue Oct 13, 2023 · 0 comments

Comments

@unscripted
Copy link
Member

unscripted commented Oct 13, 2023

What problem does this feature request address?

Currently, the theme's CSS sets several typography styles. This prevents changes in the editor from appearing on the front end. A specific use case where I encountered this issue is the styles for the header and footer needed to differ.

What is your proposed solution?

By completing the steps below, we would allow typography style changes made in the editor to affect the output of the navigation blocks.

  1. Remove font weight, size and colors from the CSS.
  2. Add the default desired font weight, size and color to the theme.json.
  3. Remove "textTransform": "uppercase" from the core/navigation block in the theme.json.
  4. Remove "fontWeight": false from the typography element of the theme.json

┆Issue is synchronized with this Asana task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant