Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS Deprecation Warning #8196

Open
MaximBalaganskiy opened this issue Jul 18, 2024 · 2 comments
Open

SASS Deprecation Warning #8196

MaximBalaganskiy opened this issue Jul 18, 2024 · 2 comments
Labels

Comments

@MaximBalaganskiy
Copy link
Contributor

MaximBalaganskiy commented Jul 18, 2024

Bug report

Compiling with "sass": "^1.77.8" produces a lot of deprecation warnings

Module Warning (from ../../node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 168, column 4 of file:///C:/Dev/Dynamik/github/verdipapir/Gui/node_modules/@material/button/_button-base.scss:168:4:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

168 |     min-width: 64px;


..\..\node_modules\@material\button\_button-base.scss 169:5                   @content
..\..\node_modules\@material\feature-targeting\_feature-targeting.scss 218:5  targets()
..\..\node_modules\@material\button\_button-base.scss 163:3                   -root-structure()
..\..\node_modules\@material\button\_button-base.scss 51:5                    -static-styles-base()
..\..\node_modules\@material\button\_button-base.scss 38:3                    static-styles()
..\..\node_modules\@material\button\_button.scss 84:3                         static-styles-without-ripple()        
..\..\node_modules\@material\button\_button.scss 79:3                         static-styles()
..\..\node_modules\@material\button\_button.scss 47:3                         styles()
..\..\node_modules\@material\button\_button.scss 115:3                        core-styles()
..\..\node_modules\@material\button\styles.scss 25:1                          @forward
..\..\node_modules\@material\button\mdc-button.scss 23:1                      @use

Expected behavior

No deprecation warnings

Your Environment:

Software Version(s)
MDC Web 14.0.0
Sass 1.77.8

Possible solution

To opt into the new behavior, wrap the declaration in & {}

@MaximBalaganskiy
Copy link
Contributor Author

A lot of projects are still using these components and with true web components on hold as well I think it makes sense to at least fix pressing issues. Once SASS makes these deprecation ERRORs we won't be able to upgrade

@hperrin
Copy link

hperrin commented Nov 18, 2024

This is one of many reasons to make a new release. (Two years of other improvements would be very welcome.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants