Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Missing export variant in index.js #159

Open
EinGeist opened this issue Jul 30, 2024 · 1 comment
Open

Web: Missing export variant in index.js #159

EinGeist opened this issue Jul 30, 2024 · 1 comment

Comments

@EinGeist
Copy link

I was trying to use the example in make_schems.md in javascript
const scheme = new DynamicScheme({
sourceColorArgb: 0xFFEB0057,
variant: Variant.VIBRANT,
isDark: false,
contrastLevel: 0.0,
primaryPalette: TonalPalette.fromInt(0xFFEB0057),
secondaryPalette: TonalPalette.fromInt(0xFFF46B00),
tertiaryPalette: TonalPalette.fromInt(0xFF00AB46),
neutralPalette: TonalPalette.fromInt(0xFF949494),
neutralVariantPalette: TonalPalette.fromInt(0xFFBC8877)
});

but when I tried to import the Variant to use in the variant argument it returned an error that there is no export named Variant I added it to index.js and now it's working I just opened this issue so that any maintainer add this line of code and fix the problem in the repo itself

thank you

@EinGeist EinGeist changed the title Missing export variant in index.js Web: Missing export variant in index.js Jul 30, 2024
@WillsterJohnson
Copy link

this issue has actually been fixed but the owners haven't pushed a release in over 3 months. The last release was seemingly mere days before this issue was addressed.

export * from './dynamiccolor/variant.js';

honestly it's completely ridiculous to sit on a patch version bump for so long.

(at) material foundation, genuinely, why was this change not released in the same moment that be615fc was merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants